Closed Bug 1655186 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24744 - Trust Tokens: Alter signing interface to take a list of issuers

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox81 fixed)

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24744 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24744
Details from upstream follow.

David Van Cleve <davidvc@chromium.org> wrote:

Trust Tokens: Alter signing interface to take a list of issuers

This is the first of two changes altering Trust Tokens to take a list of
issuers, rather than a single issuer, as an argument to its signing
operation. This first change updates the interface and code passing the
parameter's value from Blink to the network service, but keeps the
current network service functionality the same (choosing the first
issuer provided in the list, if any, and not updating the format of the
Sec-Signature / Sec-Signed-Redemption-Records constructed during the
signing operation). The second change will update the code constructing
the outgoing headers to accommodate multiple issuers.

This is a backwards-incompatible change to the interface, but Trust
Tokens is currently experimental and provides no version-to-version
compatibility guarantees.

More at
https://docs.google.com/document/u/1/d/1L7OPuLt9CE5VhT_bGGwp3xej3mehGF-mS1ZZOVX8yp4/edit#

Test: Updates iframe-attribute parsing tests, WPTs, and browser tests
Bug: 1105230
Change-Id: I00a81758a0412f3e93ad150dc4736e55c9d9bbd3
Reviewed-on: https://chromium-review.googlesource.com/2311856
WPT-Export-Revision: db7a663762313f33225175949dc10ea0638df7f1

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 11 subtests

Status Summary

Firefox

OK : 3
PASS: 9
FAIL: 14

Chrome

OK : 3
PASS: 9
FAIL: 14

Safari

OK : 3
PASS: 9
FAIL: 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/feature-policy/experimental-features/trust-token-redemption-default-feature-policy.tentative.https.sub.html
Default "trust-token-redemption" feature policy ["self"] allows same-origin iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
Default "trust-token-redemption" feature policy ["self"] allows the top-level document.: FAIL (Chrome: FAIL, Safari: FAIL)
Default "trust-token-redemption" feature policy ["self"] disallows cross-origin iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
/trust-tokens/trust-token-parameter-validation.tentative.https.html
Trust Tokens signing operations require at least one issuer URL: FAIL (Chrome: FAIL, Safari: FAIL)
Trust Tokens fetches require present type values.: FAIL (Chrome: FAIL, Safari: FAIL)
Trust Tokens fetches require valid type values.: FAIL (Chrome: FAIL, Safari: FAIL)
Trust Tokens fetches require secure issuer URLs, if provided.: FAIL (Chrome: FAIL, Safari: FAIL)
Trust Tokens fetches require valid refreshPolicy: values, if provided.: FAIL (Chrome: FAIL, Safari: FAIL)
Trust Tokens fetches require valid signRequestData values, if provided.: FAIL (Chrome: FAIL, Safari: FAIL)
Trust Tokens signing operations require valid issuer URLs, if provided.: FAIL (Chrome: FAIL, Safari: FAIL)
Trust Tokens signing operations require string issuer URLs, if provided.: FAIL (Chrome: FAIL, Safari: FAIL)
/trust-tokens/trust-token-parameter-validation-xhr.tentative.https.html
Setting XHR Trust Tokens parameters requires that the XHR request not have been sent.: FAIL (Chrome: FAIL, Safari: FAIL)
Setting XHR Trust Tokens parameters requires that the XHR request be open.: FAIL (Chrome: FAIL, Safari: FAIL)
Since localhost URLs are potentially trustworthy, setting an issuer to localhost should succeed.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/557c6c8e9d35
[wpt PR 24744] - Trust Tokens: Alter signing interface to take a list of issuers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/324855bb41cc
[wpt PR 24744] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45d49bac6ef5
[wpt PR 24744] - Trust Tokens: Alter signing interface to take a list of issuers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/89a3d269bd9c
[wpt PR 24744] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/45d49bac6ef5
https://hg.mozilla.org/mozilla-central/rev/89a3d269bd9c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.