Closed Bug 1655194 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 24747 - Fix onbeforexrselect event handler inheritance

Categories

(Core :: WebVR, task, P4)

Product:
Core
Component:
WebVR
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24747 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24747
Details from upstream follow.

Klaus Weidner <klausw@chromium.org> wrote:

Fix onbeforexrselect event handler inheritance

The onbeforexrselect event is supposed to be part of GlobalEventHandlers
and separately inherited by {HTML,MathML,SVG}Element, Window, and
Document. The current implementation had added it at the Element
level which isn't correct, causing test failures in the idlharness
test.

Update the implementation to fix the inheritance, which unfortunately
adds a bit of extra boilerplate.

Also add objects to the idlharness test to verify the inheritance.

Spec: https://immersive-web.github.io/dom-overlays/#onbeforexrselect

Fixed: 1108685
Change-Id: I8df73304b7b2d9bd93df30b78953aa9b378f8cad
Reviewed-on: https://chromium-review.googlesource.com/2317813
WPT-Export-Revision: c3cc502c92394a5038ff37f38404d92f7cf17f63

PR 24747 applied with additional changes from upstream: 0cc1eb61d81b71834c47960d5b6cc51494f92696
Component: web-platform-tests → WebVR
Product: Testing → Core
Try push failed: decision task GQN05jFyQVOPCFoI4nrrqw returned error
Try push failed: decision task ZmKgpvO_Q7qA_gKnmATVMw returned error
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d9e9f76ec89
[wpt PR 24747] - Fix onbeforexrselect event handler inheritance, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4d9e9f76ec89

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.