Closed
Bug 1655210
Opened 4 years ago
Closed 4 years ago
Too much recursion when changing OpenPGP Keys in Account Settings
Categories
(Thunderbird :: Account Manager, defect, P1)
Thunderbird
Account Manager
Tracking
(thunderbird_esr78 fixed, thunderbird79 affected)
RESOLVED
FIXED
Thunderbird 80.0
People
(Reporter: aleca, Assigned: khushil324)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
555 bytes,
patch
|
mkmelin
:
review+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
The event dispatch causes these errors:
JavaScript error: chrome://messenger/content/am-e2e.js, line 268: InternalError: too much recursion
JavaScript error: chrome://messenger/content/AccountManager.js, line 1061: InternalError: too much recursion
JavaScript error: chrome://global/content/elements/stringbundle.js, line 69: InternalError: too much recursion
These happens whenever an OpenPGP Key is selected or changed.
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → khushil324
|
|
Assignee | |
Comment 1•4 years ago
|
||
Attachment #9166052 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•4 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9166052 [details] [diff] [review] Bug-1655210_fix-too-much-recursion-OpenPGP-0.patch Review of attachment 9166052 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9166052 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•4 years ago
|
Target Milestone: --- → Thunderbird 80.0
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/461d8fe623c0
Fix Too much recursion when changing OpenPGP Keys in Account Settings. r=mkmelin DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•4 years ago
|
||
Setting flags, since it will get needed to be uplifted with bug 1653588
status-thunderbird79:
--- → affected
status-thunderbird_esr78:
--- → affected
|
Reporter | |
Comment 6•4 years ago
|
||
Comment on attachment 9166052 [details] [diff] [review] Bug-1655210_fix-too-much-recursion-OpenPGP-0.patch [Approval Request Comment] Regression caused by (bug #): bug 1653588 User impact if declined: multiple JavaScript errors caused by an infinite loop of applying the same prefs settings, and consequential CPU load spike. Testing completed (on c-c, etc.): on c-c Risk to taking this patch (and alternatives if risky): low
Attachment #9166052 -
Flags: approval-comm-esr78?
|
||
Comment 7•4 years ago
|
||
Comment on attachment 9166052 [details] [diff] [review] Bug-1655210_fix-too-much-recursion-OpenPGP-0.patch Approved for esr78
Attachment #9166052 -
Flags: approval-comm-esr78? → approval-comm-esr78+
|
||
Comment 8•4 years ago
|
||
| bugherder uplift | ||
Thunderbird 78.1.1:
https://hg.mozilla.org/releases/comm-esr78/rev/a6dd2839e091
|
|
||
Updated•3 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•