Closed Bug 1655243 Opened 4 years ago Closed 4 years ago

Intermittent toolkit/components/passwordmgr/test/mochitest/test_DOMInputPasswordAdded_fired_between_DOMContentLoaded_and_load_events.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once. Ma

Categories

(Toolkit :: Password Manager, defect, P5)

Product:
Toolkit
Component:
Password Manager
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- fixed
firefox81 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bdanforth)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1655243 - Call SimpleTest.waitForExplicitFinish() at the beginning of test_DOMInputPasswordAdded_fired_between_DOMContentLoaded_and_load_events.html. r=MattN
47 bytes, text/x-phabricator-request
Details | Review

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=311038252&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Tn1CoIy1QdWPVHfGgNkLvQ/runs/0/artifacts/public/logs/live_backing.log

[task 2020-07-25T10:53:35.938Z] 10:53:35 INFO - TEST-START | https://example.org:443/tests/toolkit/components/passwordmgr/test/mochitest/test_DOMInputPasswordAdded_fired_between_DOMContentLoaded_and_load_events.html
[task 2020-07-25T10:53:42.233Z] 10:53:42 INFO - TEST-INFO | started process screentopng
[task 2020-07-25T10:53:42.404Z] 10:53:42 INFO - TEST-INFO | screentopng: exit 0
[task 2020-07-25T10:53:42.404Z] 10:53:42 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_DOMInputPasswordAdded_fired_between_DOMContentLoaded_and_load_events.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once. Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
[task 2020-07-25T10:53:42.405Z] 10:53:42 INFO - SimpleTest.ok@https://example.org/tests/SimpleTest/SimpleTest.js:412:16
[task 2020-07-25T10:53:42.405Z] 10:53:42 INFO - afterCleanup@https://example.org/tests/SimpleTest/SimpleTest.js:1516:18
[task 2020-07-25T10:53:42.405Z] 10:53:42 INFO - executeCleanupFunction@https://example.org/tests/SimpleTest/SimpleTest.js:1581:7
[task 2020-07-25T10:53:42.405Z] 10:53:42 INFO - executeCleanupFunction@https://example.org/tests/SimpleTest/SimpleTest.js:1597:7
[task 2020-07-25T10:53:42.405Z] 10:53:42 INFO - executeCleanupFunction@https://example.org/tests/SimpleTest/SimpleTest.js:1597:7
[task 2020-07-25T10:53:42.405Z] 10:53:42 INFO - executeCleanupFunction@https://example.org/tests/SimpleTest/SimpleTest.js:1597:7
[task 2020-07-25T10:53:42.405Z] 10:53:42 INFO - executeCleanupFunction@https://example.org/tests/SimpleTest/SimpleTest.js:1597:7
[task 2020-07-25T10:53:42.405Z] 10:53:42 INFO - SimpleTest.finish@https://example.org/tests/SimpleTest/SimpleTest.js:1601:3
[task 2020-07-25T10:53:42.406Z] 10:53:42 INFO - @https://example.org/tests/SimpleTest/SimpleTest.js:1824:18
[task 2020-07-25T10:53:42.406Z] 10:53:42 INFO - callStackHandler@https://example.org/tests/SimpleTest/SimpleTest.js:274:24
[task 2020-07-25T10:53:42.406Z] 10:53:42 INFO - GECKO(32150) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2020-07-25T10:53:42.407Z] 10:53:42 INFO - GECKO(32150) | MEMORY STAT | vsize 2508MB | residentFast 113MB | heapAllocated 9MB
[task 2020-07-25T10:53:42.407Z] 10:53:42 INFO - TEST-OK | https://example.org:443/tests/toolkit/components/passwordmgr/test/mochitest/test_DOMInputPasswordAdded_fired_between_DOMContentLoaded_and_load_events.html | took 6313ms
[task 2020-07-25T10:53:43.273Z] 10:53:43 INFO - GECKO(32150) | console.warn: LoginRecipes: "getRecipes: falling back to a synchronous message for:" "https://example.org"

Bianca, please take a look.

Flags: needinfo?(bdanforth)
Regressed by: 1653138
Has Regression Range: --- → yes
Keywords: regression
Assignee: nobody → bdanforth
Status: NEW → ASSIGNED
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/608921871b27
Call SimpleTest.waitForExplicitFinish() at the beginning of test_DOMInputPasswordAdded_fired_between_DOMContentLoaded_and_load_events.html. r=MattN

Comment on attachment 9166348 [details]
Bug 1655243 - Call SimpleTest.waitForExplicitFinish() at the beginning of test_DOMInputPasswordAdded_fired_between_DOMContentLoaded_and_load_events.html. r=MattN

Beta/Release Uplift Approval Request

  • User impact if declined: There is no user impact; this fixes a test-only failure by modifying a test file.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The only file that is modified is a test file; it adds a single line to the beginning of the test added in Bug 1653138 to indicate to the test harness how to determine when the test has run to completion.
  • String changes made/needed:
Flags: needinfo?(bdanforth)
Attachment #9166348 - Flags: approval-mozilla-beta?

Comment on attachment 9166348 [details]
Bug 1655243 - Call SimpleTest.waitForExplicitFinish() at the beginning of test_DOMInputPasswordAdded_fired_between_DOMContentLoaded_and_load_events.html. r=MattN

Test-only change, doesn't need beta approval.

Attachment #9166348 - Flags: approval-mozilla-beta?

https://hg.mozilla.org/mozilla-central/rev/608921871b27

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Set release status flags based on info from the regressing bug 1653138

status-firefox79: --- → unaffected
status-firefox80: --- → affected
status-firefox-esr68: --- → unaffected
status-firefox-esr78: --- → unaffected
Regressions: 1656046
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: