Closed Bug 1655297 Opened 6 months ago Closed 5 months ago

[wpt-sync] Sync PR 24754 - Added active-selection-041.html and active-selection-043.html

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24754 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24754
Details from upstream follow.

Gérard Talbot <github@gtalbot.org> wrote:

Added active-selection-041.html and active-selection-043.html

active-selection-041.html

active-selection-043.html

reference/active-selection-041-ref.html

This is a followup of
https://github.com/web-platform-tests/wpt/pull/20931#issuecomment-650434204
and of comments made in
https://github.com/web-platform-tests/wpt/pull/20028
where @fantasai wrote
{
active-selection-041

So... the problem wth this test is that we don't actually know the exact color that the UA will use. It could be an 0.5 wash, but it doesn't have to be. We can make what you have as a MAY test, and it will be correct. I would use a blue highlight, though, to make the color purple. This will be more clearly not red than the warm brown that results from mixing the green and red.

You should also add another test for what happens if the highlight has 'color' but not 'background-color'.

Now, we want to also write a test for the full SHOULD, we will need to take a different approach.

Here is my suggestion: write two tests using your square image as the base, as follows:

  • For the first test, mask over the image with an inline element that has 4px top+bottom padding and a background. (If the UA highlights only this area, as if it was a regular inline element, it's insufficient. I think this would be the most likely error.) Use a "mismatch" reference against a version of the test without the highlight. This ensures that the UA has highlighted the image somehow, including outside the masked area.

  • For the second test, mask over the entire square image. Use a "match" reference against a version of the test without the highlight. This ensures the highlight doesn't leak outside the image area.

Think about this, and let me know if you think it is a good approach or if you have some other ideas. It's a tricky thing to test because we don't know what will be the exact rendering. :)
}

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/active-selection-043.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b700a58216b
[wpt PR 24754] - Added active-selection-041.html and active-selection-043.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/56564edb3041
[wpt PR 24754] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd43b44ef177
[wpt PR 24754] - Added active-selection-041.html and active-selection-043.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8e26847c73c1
[wpt PR 24754] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.