1655392 - Split `HTMLEditor::HandleDeleteNonCollapsedSelection()` to range computation part and modifying DOM tree part

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1655392 - part 1: Move some part of `HTMLEditor::HandleDeleteNonCollapsedRanges()` to `AutoBlockElementsJoiner` r=m_kato!

For making the following review easier, this patch just moves some part of
HandleDeleteNonCollapsedRanges() into AutoBlockElementJoiner.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1655392 - part 2: Make `AutoBlockElementsJoiner::PrepareToDeleteNonCollapsedRange()` initialize `mLeftContent` and `mRightContent` with inclusive ancestor block elements of start and end of first range r=m_kato!

Depends on D86786

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1655392 - part 3: Give independent mode and handler for first case of `AutoBlockElementsJoiner::HandleDeleteNonCollapsedRanges()` r=m_kato!

Depends on D86787

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1655392 - part 4: Give independent mode and handler for the next block of `AutoBlockElementsJoiner::HandleDeleteNonCollapsedRanges()` r=m_kato!

And now, HTMLEditor::JoinNodesDeepWithTransaction() is used only by
AutoBlockElementsJoiner. Therefore, this patch moves it to the
stack only class.

Depends on D86788

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1655392 - part 5: Split the part removing contents in each range off from `HandleDeleteNonCollapsedRanges()` r=m_kato!

Depends on D86789

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1655392 - part 6: Split the text deletion part of start and/or end of range off from `HandleDeleteNonCollapsedRanges` r=m_kato!

Depends on D86790

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98e111c5d4f8
part 1: Move some part of `HTMLEditor::HandleDeleteNonCollapsedRanges()` to `AutoBlockElementsJoiner` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a43d7d809031
part 2: Make `AutoBlockElementsJoiner::PrepareToDeleteNonCollapsedRange()` initialize `mLeftContent` and `mRightContent` with inclusive ancestor block elements of start and end of first range r=m_kato
https://hg.mozilla.org/integration/autoland/rev/38ba9a183361
part 3: Give independent mode and handler for first case of `AutoBlockElementsJoiner::HandleDeleteNonCollapsedRanges()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/87df7862ec99
part 4: Give independent mode and handler for the next block of `AutoBlockElementsJoiner::HandleDeleteNonCollapsedRanges()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/22cd85ed8594
part 5: Split the part removing contents in each range off from `HandleDeleteNonCollapsedRanges()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/17a9c92b557a
part 6: Split the text deletion part of start and/or end of range off from `HandleDeleteNonCollapsedRanges` r=m_kato

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/98e111c5d4f8
https://hg.mozilla.org/mozilla-central/rev/a43d7d809031
https://hg.mozilla.org/mozilla-central/rev/38ba9a183361
https://hg.mozilla.org/mozilla-central/rev/87df7862ec99
https://hg.mozilla.org/mozilla-central/rev/22cd85ed8594
https://hg.mozilla.org/mozilla-central/rev/17a9c92b557a