Closed Bug 1655392 Opened 6 months ago Closed 5 months ago

Split `HTMLEditor::HandleDeleteNonCollapsedSelection()` to range computation part and modifying DOM tree part

Categories

(Core :: DOM: Editor, task, P2)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(6 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
Severity: -- → S3
Priority: -- → P2

For making the following review easier, this patch just moves some part of
HandleDeleteNonCollapsedRanges() into AutoBlockElementJoiner.

And now, HTMLEditor::JoinNodesDeepWithTransaction() is used only by
AutoBlockElementsJoiner. Therefore, this patch moves it to the
stack only class.

Depends on D86788

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/98e111c5d4f8
part 1: Move some part of `HTMLEditor::HandleDeleteNonCollapsedRanges()` to `AutoBlockElementsJoiner` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a43d7d809031
part 2: Make `AutoBlockElementsJoiner::PrepareToDeleteNonCollapsedRange()` initialize `mLeftContent` and `mRightContent` with inclusive ancestor block elements of start and end of first range r=m_kato
https://hg.mozilla.org/integration/autoland/rev/38ba9a183361
part 3: Give independent mode and handler for first case of `AutoBlockElementsJoiner::HandleDeleteNonCollapsedRanges()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/87df7862ec99
part 4: Give independent mode and handler for the next block of `AutoBlockElementsJoiner::HandleDeleteNonCollapsedRanges()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/22cd85ed8594
part 5: Split the part removing contents in each range off from `HandleDeleteNonCollapsedRanges()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/17a9c92b557a
part 6: Split the text deletion part of start and/or end of range off from `HandleDeleteNonCollapsedRanges` r=m_kato
You need to log in before you can comment on or make changes to this bug.