1655395 - Handle egl->fStreamConsumerGLTextureExternalAttribsNV() error in RenderDXGITextureHostOGL

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

When error happns at egl->fStreamConsumerGLTextureExternalAttribsNV(), MOZ_ALWAYS_TRUE triggers process abort. It is not good.

• https://searchfox.org/mozilla-central/rev/cf561cece0ca9aeaf0202e68699836d957d0c670/gfx/webrender_bindings/RenderD3D11TextureHostOGL.cpp#154

See Bug 1652403 comment 3.

Comment 1

[Sotaro Ikeda [:sotaro]]

I looked into the implementation of EGL_StreamConsumerGLTextureExternalAttribsNV(). It does not cause a context lost. Then context seemed to be lost before calling the function.

• https://searchfox.org/mozilla-central/rev/c6676771df58c6e0098574bc6b11517acbf264cf/gfx/angle/checkout/src/libANGLE/Stream.cpp#124
• https://searchfox.org/mozilla-central/rev/c6676771df58c6e0098574bc6b11517acbf264cf/gfx/angle/checkout/src/libGLESv2/entry_points_egl_ext.cpp#770

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1655395 - Remove MOZ_ALWAYS_TRUE from RenderDXGITextureHostOGL

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2420148af8e
Remove MOZ_ALWAYS_TRUE from RenderDXGITextureHostOGL r=nical

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e2420148af8e