1655412 - NetMonitor - Center icon in [Start performance analysis] button

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot 0002-07-27 at 12.29.14.png

Affected versions

• 80.0a1(2020-07-23), 79.0b9;

Affected platforms

• Windows 10, macOS 10.15, Ubuntu 18;

Steps to reproduce

1. Launch Firefox, open any webpage;
2. enable Devtools - Network Monitor tab;
3. Observe the bottom-left button;

Expected result

• icon centered in button;

Actual result

• icon is clamped to bottom side of button;

Regression range

• considering as good part of the range the last changes to the button; where the icon was on the top-side of the button(it still not being center-ed); prior to this the icon was center-ed - with a different icon;
• First bad: 2020-05-13;
• Last good: 2020-05-12;
• Pushlog: URL;

Additional notes

• attached screenshot with the issue;
• S4 as suggested severity.

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Bug 1655412 - Vertically centered 'Start performance analysis' button in Network Monitor. r=ladybenko

Comment 2

[Sebastian Zartner [:sebo]]

To be precise, the change was caused by https://hg.mozilla.org/mozilla-central/rev/bd0638c0c5579bef09253122984544287bb8ce67. I've now made the button two pixels higher to get a little padding around the icon and vertically centered it.

Sebastian

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fed9ba840375
Vertically centered 'Start performance analysis' button in Network Monitor. r=ladybenko

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fed9ba840375