Upper case PDF extension will not offer "Open in Nightly" option
Categories
(Firefox :: File Handling, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: kernp25, Assigned: Gijs)
References
Details
Attachments
(6 files)
This line must be changed to this:
primaryExtension.toLowerCase() == "pdf" &&
Because, this.mLauncher.MIMEInfo.primaryExtension
returns PDF
.
Assignee | ||
Comment 2•4 years ago
|
||
Do you have a testcase? What mimetype is the server sending?
I'd actually expect the mime info object to lowercase the file extension...
(In reply to :Gijs (he/him) from comment #2)
Do you have a testcase? What mimetype is the server sending?
I'd actually expect the mime info object to lowercase the file extension...
Is the screenshot enough?
I added this.mLauncher.MIMEInfo
to https://searchfox.org/mozilla-central/rev/0e309417bdc73be33fc93f6bd7a0d4063d2c6e51/toolkit/mozapps/downloads/HelperAppDlg.jsm#1273.
I changed dummy.pdf
to dummy.PDF
and the primaryExtension
was PDF
.
Assignee | ||
Comment 7•4 years ago
|
||
As I said, I think the issue is that the primaryExtension
should be normalized... I'll try to take a look at what's going on in the mime service after sleep...
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 9•4 years ago
|
||
Depends on D85927
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d00bcc7e317a always lowercase file extensions used in the Windows external helper app code, r=mak https://hg.mozilla.org/integration/autoland/rev/840272088ab1 improve case handling when normalizing file names in contentAreaUtils.js, r=mak
Comment 11•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d00bcc7e317a
https://hg.mozilla.org/mozilla-central/rev/840272088ab1
Assignee | ||
Comment 12•4 years ago
|
||
Can you confirm if this works correctly for you in tomorrow's nightly? Thanks.
Reporter | ||
Comment 13•4 years ago
|
||
(In reply to :Gijs (he/him) from comment #12)
Can you confirm if this works correctly for you in tomorrow's nightly? Thanks.
I will test tomorrow.
Reporter | ||
Comment 14•4 years ago
|
||
Description
•