Closed Bug 1655457 Opened 4 years ago Closed 4 years ago

Upper case PDF extension will not offer "Open in Nightly" option

Categories

(Firefox :: File Handling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: kernp25, Assigned: Gijs)

References

Details

Attachments

(6 files)

Attached image firefox_nSE0u8OvYb.png

This line must be changed to this:

primaryExtension.toLowerCase() == "pdf" &&

Because, this.mLauncher.MIMEInfo.primaryExtension returns PDF.

Flags: needinfo?(gijskruitbosch+bugs)

Would checking the MIME type also work?

Do you have a testcase? What mimetype is the server sending?

I'd actually expect the mime info object to lowercase the file extension...

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(kernp25)
Attached image firefox_qxKkO5WgLw.png

(In reply to :Gijs (he/him) from comment #2)

Do you have a testcase? What mimetype is the server sending?

I'd actually expect the mime info object to lowercase the file extension...

Is the screenshot enough?

I added this.mLauncher.MIMEInfo to https://searchfox.org/mozilla-central/rev/0e309417bdc73be33fc93f6bd7a0d4063d2c6e51/toolkit/mozapps/downloads/HelperAppDlg.jsm#1273.

Flags: needinfo?(kernp25)
Attached file dummy.PDF

I changed dummy.pdf to dummy.PDF and the primaryExtension was PDF.

Flags: needinfo?(gijskruitbosch+bugs)

As I said, I think the issue is that the primaryExtension should be normalized... I'll try to take a look at what's going on in the mime service after sleep...

Attachment #9167662 - Attachment mime type: application/pdf → application/octet-stream
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9168007 - Attachment description: Bug 1655457 - always lowercase file extensions for lookup in the mime service, r?mak → Bug 1655457 - always lowercase file extensions used in the Windows external helper app code, r?mak
Severity: -- → S3
Priority: -- → P2
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d00bcc7e317a
always lowercase file extensions used in the Windows external helper app code, r=mak
https://hg.mozilla.org/integration/autoland/rev/840272088ab1
improve case handling when normalizing file names in contentAreaUtils.js, r=mak
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Can you confirm if this works correctly for you in tomorrow's nightly? Thanks.

Flags: needinfo?(kernp25)

(In reply to :Gijs (he/him) from comment #12)

Can you confirm if this works correctly for you in tomorrow's nightly? Thanks.

I will test tomorrow.

Attached image firefox_mx0Wl51JL2.png

Works perfectly!

Flags: needinfo?(kernp25)
Regressions: 1670356
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: