1655486 - Support search mode across sessions

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Marco Bonardo [:mak]]

When we store the typed text for a browser, we should probably also store search mode.

Use-cases:
a) I start searching in a tab, move to a different window/tab to copy something, go back and expect to still be in search mode with the appropriate engine
b) I restart the browser with a typed search, it should go restore that browser in search mode with my typed search

Comment 1

[Harry Twyford]

This seems like it could be a dupe of bug 1647899? Although the scope of this bug is wider.

Comment 2

[Marco Bonardo [:mak]]

let's transform this to track windows and sessions only, just in case.

Comment 3

[Harry Twyford]

Pointing out bug 1647899 comment 6 over here, since it could form a good basis for this work.

Comment 4

[Marco Bonardo [:mak]]

I think a) now works as expected, so the only remaining thing here is Session Restore.

Comment 5

[Marco Bonardo [:mak]]

in https://bugzilla.mozilla.org/show_bug.cgi?id=1647899#c7 Drew suggested to keep storing info in the urlbar, so potentially we can just have session store interact with the urlbar modules to apply and retrieve the state.

Comment 6

[Drew Willcoxon :adw]

Attachment: Bug 1655486 - Support search mode across sessions.

This is a WIP that basically works, but it needs more tests and some rough edges
smoothed out.

Comment 7

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60ed50b6d07b8bd8411205e9fa6a4150015e90a7

Comment 8

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e2db0b7967cd2436243eb5abe31179b303d9f0

Comment 9

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb92fca37d141f39a4ea2404ee09caf278bde5ee

Comment 10

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab70388b329eecb098443b6522545e3391788635

Comment 11

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a39a8ee08703c1c474f625a96d248b9350b0216

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b3560927e84
Support search mode across sessions. r=mak

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9b3560927e84