1655516 - [wpt-sync] Sync PR 24767 - Revert "Reland "Do not expose media devices before a successful getUserMedia()""

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24767 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24767
Details from upstream follow.

Adithya Srinivasan <[e-mail]> wrote:

Revert "Reland "Do not expose media devices before a successful getUserMedia()""

This reverts commit 8b10bc20f5a16c1257a472c70afa0cd58c49a8be.

Reason for revert: camera.CCAUISanity.fake is failing again: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/27932

Original change's description:

Reland "Do not expose media devices before a successful getUserMedia()"

This reverts commit 69a6001995c51516b403dbde99a2db4c5054ce55.

chrome-prefixed URLs are exempted from the getUserMedia() requirement.

Original change's description:

Revert "Do not expose media devices before a successful getUserMedia()"

This reverts commit d64e736aa8c7976b12b33f92472f7950bf0215b9.

Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680

Original change's description:

Do not expose media devices before a successful getUserMedia()

This is a spec-compliance change.

This CL also adds some improvements to the blink MediaDevices unit test.

Bug: 1101860
Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808
Commit-Queue: Guido Urdaneta \<[e-mail]>
Reviewed-by: Harald Alvestrand \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#786253}

TBR=[e-mail],[e-mail]

Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282
Reviewed-by: Mohsen Izadi \<[e-mail]>
Commit-Queue: Mohsen Izadi \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#786615}

TBR=[e-mail],[e-mail],[e-mail]

Not skipping CQ checks because this is a reland.

Bug: 1101860
Change-Id: I3fb6d9a620291cda57eb5fe48ce330b45425a5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289833
Commit-Queue: Guido Urdaneta \<[e-mail]>
Reviewed-by: Guido Urdaneta \<[e-mail]>
Reviewed-by: Harald Alvestrand \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#791797}

TBR=[e-mail],[e-mail],[e-mail],[e-mail]

Change-Id: I6b18c308de10dc5e5251025fd887892ecfef938b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101860

Reviewed-on: https://chromium-review.googlesource.com/2320081
WPT-Export-Revision: adaf23db09636cbf5a0773c800cb7766e23befc2

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f31cd9c767847d334b23bf08262190dca61852c

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4612718a40869633e753172e1ed42586bdc01050

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 6 subtests

Status Summary

Firefox

OK : 3
PASS: 157[GitHub] 160[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug]
FAIL: 21[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] 24[GitHub]

Chrome

OK : 3
PASS: 188
FAIL: 1

Safari

OK : 3
PASS: 157
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/mediacapture-streams/idlharness.https.window.html
MediaStreamTrack interface: operation getCapabilities(): FAIL
MediaStreamTrack interface: track must inherit property "getCapabilities()" with the proper type: FAIL

New Tests That Don't Pass

/audio-output/setSinkId.https.html
List device, setSinkId should be allowed on the default, the rest of the devices will get a NotAllowedError: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: FAIL, Safari: FAIL)
setSinkId fails with NotFoundError on made up deviceid: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: PASS, Safari: FAIL)
setSinkId on default audio output should always work: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: PASS, Safari: FAIL)
/mediacapture-streams/idlharness.https.window.html
Navigator interface: operation getUserMedia(MediaStreamConstraints, NavigatorUserMediaSuccessCallback, NavigatorUserMediaErrorCallback): FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: audioinput must inherit property "getCapabilities()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: videoinput must inherit property "getCapabilities()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface object name: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo must be primary interface of videoinput: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface object length: FAIL (Chrome: PASS, Safari: FAIL)
MediaStreamTrack interface: operation getCapabilities(): FAIL (Chrome: PASS, Safari: PASS)
MediaStreamTrack interface: track must inherit property "getCapabilities()" with the proper type: FAIL (Chrome: PASS, Safari: PASS)
Navigator interface: navigator must inherit property "getUserMedia(MediaStreamConstraints, NavigatorUserMediaSuccessCallback, NavigatorUserMediaErrorCallback)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
Stringification of videoinput: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo must be primary interface of audioinput: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: operation getCapabilities(): FAIL (Chrome: PASS, Safari: FAIL)
Stringification of audioinput: FAIL (Chrome: PASS, Safari: FAIL)
Navigator interface: calling getUserMedia(MediaStreamConstraints, NavigatorUserMediaSuccessCallback, NavigatorUserMediaErrorCallback) on navigator with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
/mediacapture-streams/MediaDevices-getUserMedia.https.html
getUserMedia() fails with exact invalid resizeMode.: FAIL (Chrome: PASS, Safari: FAIL)
getUserMedia() supports setting none as resizeMode.: FAIL (Chrome: PASS, Safari: FAIL)
getUserMedia() supports setting crop-and-scale as resizeMode.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6803f73bf0ac
[wpt PR 24767] - Revert "Reland "Do not expose media devices before a successful getUserMedia()"", a=testonly

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6803f73bf0ac