1655528 - Replace uses of nsDocShell::GetAllDocShellsInSubtree in toolkit/components/extensions/

Status: RESOLVED WONTFIX

(WebExtensions :: General, task, P2)

Description

[u608768]

There's currently 3 uses of this function in toolkit/components/extensions/:

1. ForEachDocShell in ExtensionPolicyService.cpp
2. ExtensionContent.enumerateWindows (which appears to be dead code)
3. WebNavigationFrames.iterateDocShellTree

Comment 1

[u608768]

Attachment: Bug 1655528 - Replace nsDocShell::GetAllDocShellsInSubtree in ForEachDocShell, r?kmag

Comment 2

[u608768]

Attachment: Bug 1655528 - Use BrowsingContexts instead of docShells in WebNavigationFrame.jsm, r?kmag

This also removes an unused helper function.

Depends on D85340

Comment 3

[u608768]

After looking into the usages from comment 0 a little more, I'm fairly certain that neither of them (ignoring #2) will do anything with out-of-process docshells. We don't plan on removing GetAllDocShellsInSubtree any time soon, so we can probably just WONTFIX this bug. But I might be missing something -- zombie, can you take a quick look and verify?

Comment 4

[Tomislav Jovanovic :zombie]

(In reply to :kashav from comment #3)

After looking into the usages from comment 0 a little more, I'm fairly certain that neither of them (ignoring #2) will do anything with out-of-process docshells. We don't plan on removing GetAllDocShellsInSubtree any time soon, so we can probably just WONTFIX this bug. But I might be missing something -- zombie, can you take a quick look and verify?

Yeah, for #1, we run that from a process script, so docshells from each process are handled in the same process, that code doesn't need to care about OOP docshells.

For #3, the better approach would be to read all the info (via BCs) from the parent process, not message the child process and then use BCs to read the same info. :)

In any case, #3 would be part of bug 1581859, so yeah, i think we can close this.