1655573 - The placeholder string "Search <Ctrl+K>" in the Gloda searchbox should be moved to the right

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect, P2)

Description

[Jorg K (CEST = GMT+2)]

In TB 68 I count three pixels between the border and the placeholder text, in TB 78 I see only two. Four would possibly be best. That's on Windows 10.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1655573-searchbox-padding.patch

Using now 4px padding on the left of the searchbox on Linux and Windows.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9167115 [details] [diff] [review]
1655573-searchbox-padding.patch

Review of attachment 9167115 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9167115 [details] [diff] [review]
1655573-searchbox-padding.patch

[Approval Request Comment]
User impact if declined: Not correct padding in searchbox
Testing completed (on c-c, etc.): almost in c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/40f204163d48
Give the search boxes the correct padding. r=aleca DONTBUILD

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9167115 [details] [diff] [review]
1655573-searchbox-padding.patch

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/cb36a7221d87

Comment 7

[WaltS48 [:walts48]]

Looks okay to me testing the 80.0b2 release candidate on Ubuntu 18.04.4.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9167115 [details] [diff] [review]
1655573-searchbox-padding.patch

[Triage Comment]
Approved for esr78

Comment 9

[Geoff Lankow (:darktrojan)]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/f225bc620658