Open Bug 1655654 Opened 4 years ago Updated 2 years ago

On youtube when playing video, after closing an ad, key commands for playback don't work, when `accessibility.typeaheadfind=true`

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Version:
78 Branch
Type:
defect

Tracking

()

Status:
UNCONFIRMED

People

(Reporter: mail, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

  • start video playback on youtube.com
  • wait until an ad appears
  • click on the x to close ad
  • press F,J,K or L

Actual results:

keyboard commands don't work as expected, instead the search bar appears and displays the keys pressed.

Expected results:

F should toggle between fullscreen, K should start/stop playback and so on.

There is a workaround: when you click onto the video after closing the ad, the key controls work again but with the drawback that you stop the video by clicking.

So you always have to do the following sequence when an ad appears: close ad, click on the video, press K to start playback again. Very annoying.

Summary: On youtube when playing video, after closing an ad, key commands for playback doesn't work → On youtube when playing video, after closing an ad, key commands for playback don't work

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Video/Audio Controls
Product: Firefox → Toolkit

Youtube doesn't use our builtin video controls, so moving this to the right component - it sounds like focus is lost and so the page isn't getting to the key events before the quick find bar does.

Component: Video/Audio Controls → DOM: UI Events & Focus Handling
Product: Toolkit → Core

I could not reproduce this on 78 and nightly on Mac. Daniel, could someone from the QA team help to reproduce this? Thanks.

Flags: needinfo?(daniel.bodea)

I can't reproduce this either. I assume that it is not related to the ads that can be "skipped", but to the banner ads that are being displayed during videos, over them. Either case, I could not reproduce it. The keyboard shortcuts worked properly even right after closing the banner ads displayed over videos. It has been tested on a MacBook with mac os 10.15.5, on Firefox esr v78.1.0esr, Firefox Release v79.0, Firefox Beta v80.0b2 and Nightly v81.0a1.

I assume that the ads that you close aren't browser ads, but some third-party provider.

Oliver, Can you please record your screen while reproducing the issue? We need to determine exactly what kind of ads you are closing.
Also, which mac os version are you reproducing this on?

Flags: needinfo?(daniel.bodea) → needinfo?(mail)

No Mac! Sorry, I never said mac. I'm using FF 79.0 on Win10 1909, build 18363.959.

I recorded a video:
3:14 - ad appears
3:19 - I clicked the ad away (mouse pointer not captured)
3:22 - I pressed k on my keyboard. Result: not the expected function (stop video), instead the search bar appears.
I hope it helps!

Best regards
Oliver

Flags: needinfo?(mail)

My recording was too big to upload, here's a link:
https://drive.google.com/file/d/1M0v4YHcVUbRPpUu3l-MmMk4WVHXeObr7/view?usp=sharing

I don't reproduce this on Nightly on Win10. However, I see a difference, when I click "skip" button of an add, focus is back to <body> element. However, when I click "X" button of ad's banner, focus is back to <div id="movie_player">. I guess that when this is reproduced, focus is not back to the document nor the player.

Hi Daniel,
Could someone from the QA team help to reproduce on Win10? Thank you.

Flags: needinfo?(daniel.bodea)

I have reattempted to reproduce on 2 different Windows 10 machines, but couldn't. The keys work every time correctly in my case in any situation I can imagine. If your case, the browser in trying to perform a search on the page instantly (without pressing CTRL+F). Something is fishy.

Can you please go to the about:support page and copy the contents of the page into a comment of the bug?
I want to see which add-ons you use and maybe other information that might help to investigate the issue.

Flags: needinfo?(daniel.bodea) → needinfo?(mail)

(In reply to Bodea Daniel [:danibodea] from comment #9)

I have reattempted to reproduce on 2 different Windows 10 machines, but couldn't. The keys work every time correctly in my case in any situation I can imagine. If your case, the browser in trying to perform a search on the page instantly (without pressing CTRL+F). Something is fishy.

Can you please go to the about:support page and copy the contents of the page into a comment of the bug?
I want to see which add-ons you use and maybe other information that might help to investigate the issue.

This sounds like the difference between having accessibility.typeaheadfind turned on/off. Can you retry with that pref set to true?

Flags: needinfo?(daniel.bodea)

I will do

Flags: needinfo?(mail)

:Gijs: I can properly reproduce the issue by turning the "accessibility.typeaheadfind" pref as TRUE.
Oliver: Can you also go to the "about:config" page of your affected browser, search for the "accessibility.typeaheadfind" pref and tell us what value it has?

Thank you.

Flags: needinfo?(mail)
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(daniel.bodea)

(In reply to Edgar Chen [:edgar] from comment #3)

I could not reproduce this on 78 and nightly on Mac. Daniel, could someone from the QA team help to reproduce this? Thanks.

Edgar, can you retry after setting accessibility.typeaheadfind to true?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Bodea Daniel [:danibodea] from comment #12)

:Gijs: I can properly reproduce the issue by turning the "accessibility.typeaheadfind" pref as TRUE.

As stated before, this issue is definitely reproducible on Windows 10 after setting the pref you mentioned to true, by using the steps in comment 0.
I assume that you want me to also try it on Mac OS, so I'll also try Ubuntu 20 with this occasion:
So the complete results are:

  1. Windows 10: actual result: When tapping the "k" key on the keyboard, the video is paused AND the "k" string is searched on the page.
  2. Mac 10.15: actual result: When tapping the "k" key on the keyboard, the video is paused and the "k" string is NOT searched on the page.
  3. Ubuntu 20: actual result: When tapping the "k" key on the keyboard, the video is paused AND the "k" string is searched on the page. (like on Windows).

In conclusion, it appears that mac is behaving differently than Windows and Ubuntu in this case.
I have to mention that I do not know what the expected behaviour is, right now. Is Mac OS behaving correctly?

Oliver, can you give us the info about the value of the "accessibility.typeaheadfind" pref from "about:config" page (also requested in comment 12)?

P.S. Please Ni me when requesting testing information. Thank you.

Flags: needinfo?(gijskruitbosch+bugs)

Yes, can confirm! accessibility.typeaheadfind is true on my machine.

Flags: needinfo?(mail)

(In reply to :Gijs (he/him) from comment #13)

(In reply to Edgar Chen [:edgar] from comment #3)

I could not reproduce this on 78 and nightly on Mac. Daniel, could someone from the QA team help to reproduce this? Thanks.

Edgar, can you retry after setting accessibility.typeaheadfind to true?

+ni for this. :-)

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(echen)

I got the same result as comment #14,

Windows 10: actual result: When tapping the "k" key on the keyboard, the video is paused AND the "k" string is searched on the page.
Mac 10.15: actual result: When tapping the "k" key on the keyboard, the video is paused and the "k" string is NOT searched on the page.

I also noticed a difference between Windows and Mac, after clicking "X" button of ad's banner

  • Windows 10: focus back to <body> element.
  • Mac: focus back to <div id="movie_player" ...> element.

Maybe this is why they behave differently.

Flags: needinfo?(echen)
Severity: -- → S3
Summary: On youtube when playing video, after closing an ad, key commands for playback don't work → On youtube when playing video, after closing an ad, key commands for playback don't work, when `accessibility.typeaheadfind=true`
You need to log in before you can comment on or make changes to this bug.