Closed Bug 1655684 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 24777 - Revert "[COOP] Access reporting. Fix the python server."

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24777 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24777
Details from upstream follow.

Tim Schumann <tschumann@chromium.org> wrote:

Revert "[COOP] Access reporting. Fix the python server."

This reverts commit 9c96261a884c9ebd9daff66b7e41398d65c9d11c.

Reason for revert: This appears to have broken external/wpt/html/cross-origin-opener-policy/reporting/access-reporting/openee-accessed_openee-coop-ro.https.html

BUG: 1110254

Original change's description:

[COOP] Access reporting. Fix the python server.

A python server is used has a communication channel in between documents
from different browsing context group and potentially cross-origin.

There are two methods:

  • one for writing a message.
  • one for reading the message.

I initially supposed we won't need to store more than one message in the
stash. It turns out there are tests doing two write in a row without any
read in the middle. It was throwing an exception when this
happened.

This patch makes the server to maintain a queue of messages instead. It
doesn't throw errors anymore.

Bug: chromium:1109194
Change-Id: I25f8dc2c2a032781a4527a0994e94e46f85e12c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317865
Reviewed-by: Pâris Meuleman \<pmeuleman@chromium.org>
Commit-Queue: Arthur Sonzogni \<arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791901}

TBR=clamy@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org

Change-Id: I87ba2caa07f80f42aa549929ade392485b968d6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1109194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320572
Reviewed-by: Tim Schumann \<tschumann@chromium.org>
Commit-Queue: Tim Schumann \<tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792184}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7ba434b1d79
[wpt PR 24777] - Revert "[COOP] Access reporting. Fix the python server.", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.