1655686 - Migrate address books with bad filenames

Status: RESOLVED FIXED

(Thunderbird :: Address Book, task)

Description

[Geoff Lankow (:darktrojan)]

In bug 1653234 we discovered that address books with an extra dot in the filename failed to initialise. We should change the migration step to avoid this, and maybe try to fix books that have already been migrated.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1655686 - Fix migration of address books with a dot in the file name. r?mkmelin

The migration was failing for address books that have been through the previous migration and have
a file name like foo.na2.mab. This is because the AddrBookDirectory.init wasn't expecting a dot in
the file name, which I've changed.

In addition, migration wouldn't happen where the dirType pref is the default value (2 in earlier
versions, 101 now) but the file name is not the default (abook.mab or history.mab), so I've fixed
that here too.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1655686 - On migration, remove the old .na2 extension from address book file names. r?mkmelin

It doesn't make sense to remove the .mab extension on migration, but not remove the earlier .na2
extension.

Also adds a check that other unusual but valid file names are migrated.

Depends on D85832

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1655686 - Migrate all address book preferences before any address book contacts. r?mkmelin

This prevents (mostly harmless, I think) error messages in the migration process.

Depends on D85833

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/52d578abd339
Fix migration of address books with a dot in the file name. r=mkmelin
https://hg.mozilla.org/comm-central/rev/703cb3c4144a
On migration, remove the old .na2 extension from address book file names. r=mkmelin
https://hg.mozilla.org/comm-central/rev/4212bbca8156
Migrate all address book preferences before any address book contacts. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9167836 [details]
Bug 1655686 - Fix migration of address books with a dot in the file name. r?mkmelin

Requesting approval for all three patches. There's some risk here, not to beta because this is for the 68->78 migration, but I'd appreciate it being tested as much as possible (68->this).

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9167836 [details]
Bug 1655686 - Fix migration of address books with a dot in the file name. r?mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/4b4d3b13bf7c
https://hg.mozilla.org/releases/comm-beta/rev/14a252d9cfea
https://hg.mozilla.org/releases/comm-beta/rev/cb07c4bd4a77

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9167836 [details]
Bug 1655686 - Fix migration of address books with a dot in the file name. r?mkmelin

[Triage Comment]
Approved for esr78

Rob, please take this on a respin of 78.1.2 (and the other 3 patches).

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9167837 [details]
Bug 1655686 - On migration, remove the old .na2 extension from address book file names. r?mkmelin

[Triage Comment]
Approved for esr78 (already landed on beta)

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9167838 [details]
Bug 1655686 - Migrate all address book preferences before any address book contacts. r?mkmelin

[Triage Comment]
Approved for esr78 (already landed on beta)

Comment 11

[Rob Lemley [:rjl]]

(In reply to Wayne Mery (:wsmwk) from comment #8)

Rob, please take this on a respin of 78.1.2 (and the other 3 patches).

Three? The three on this bug and one more from?

Comment 12

[Wayne Mery (:wsmwk)]

I think I meant to say the other two - all from this bug

Comment 13

[Geoff Lankow (:darktrojan)]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/89180bb4820a
https://hg.mozilla.org/releases/comm-esr78/rev/499b5d7e741a
https://hg.mozilla.org/releases/comm-esr78/rev/0645ee6bf48b