1655688 - Make the event/alarm dialog themeable

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Richard Marti (:Paenglab)]

The event/alrm dialogs aren't any more themeable. This looks weird especially in editInTab mode when all other TB elements are dark and only this dialog not.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1655688-event-dialog-themeable.patch

This makes the dialog in editInTab mode and also in stand-alone dialog mode themeable.

I also fixed some block-aligning in the CSS files.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9166512 [details] [diff] [review]
1655688-event-dialog-themeable.patch

Review of attachment 9166512 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, both the code changes (hooray for better CSS formatting) and the dark mode on the edit event dialog.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9166512 [details] [diff] [review]
1655688-event-dialog-themeable.patch

[Approval Request Comment]
User impact if declined: inconsistent dark mode
Testing completed (on c-c, etc.): ready to go to c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2573f732fd2c
Make the event/alarm dialog themeable. r=pmorris

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9166512 [details] [diff] [review]
1655688-event-dialog-themeable.patch

Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 80.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/ff67b55d613d

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9166512 [details] [diff] [review]
1655688-event-dialog-themeable.patch

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.1.1:
https://hg.mozilla.org/releases/comm-esr78/rev/254e400dc947

Comment 9

[Geoff Lankow (:darktrojan)]

Follow-up on 78.1.1 to use -moz-appearance instead of appearance:
https://hg.mozilla.org/releases/comm-esr78/rev/d7413c571ed1c26e4055cb87f0f1dc6b8a0ede3a