1655708 - about:telemetry's sidebar gets hidden on browser window resize

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: aboutTelemetry.gif

Affected versions

• 81.0a1 (BuildId:20200727203201)
• 80.0b1 (BuildId:20200727193419)
• 79.0 (BuildId:20200720193547)
• 78.1.0esr (BuildId:20200722151235)

Unaffected versions

• 68.10.0esr (BuildId:20200622191537)

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit
• macOS 10.14

Steps to reproduce

1. Launch Firefox.
2. Access the about:telemetry page.
3. Reduce the browser window width.

Expected result

• All about:telemetry elements are responsive to the browser window width change and are successfully visible.

Actual result

• The about:telemetry sidebar becomes hidden if the browser window width is reduced.

Regression Range

• This seems to be a regression:
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cb87343d4976405a9d9eece15fc1afca7eb7b81d&tochange=e1672b3231e9e612465168f16190a1392b422517
• Possible Regressor: Bug 1525178

Notes

• For further information regarding this issue please observe the attached screencast.
• [Suggested Severity] I would recommend marking this as S4 since this is a cosmetic issue.
• Please feel free to change the component if this doesn't fit here.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Mark!

It seems that mozregression pointed out Bug 1525178 - Part 6: Change about:addons category on keyboard nav r=rpl for causing this regression.

I'm not sure about the result since your patch targeted the about:addons page.

Could you please take a look?

Thank you!

Comment 2

[Mark Striemer [:mstriemer]]

Yes, that but is likely what caused this. It would've been the Bug 1525178 - Part 3: Add second about:addons sidebar in HTML change which would've regressed this.

Adding the category-no-icon class to each category without an icon should fix it.

Comment 3

[Chris H-C :chutten]

Attachment: Bug 1655708 - about:telemetry categories have no icons r?janerik!

This will ensure that the don't disappear when the window gets narrow.

Also, I've tweaked some styles so the spacing works better without icons.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51d62a946a24
about:telemetry categories have no icons r=janerik

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/51d62a946a24

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:chutten, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 81.0a1 (BuildId:20200802214843) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit