1655816 - Overlong input fields for First/Last Name on New/Edit Contact/vCard dialog (e.g. Japanese version, mail.addr_book.show_phonetic_fields="true")

Status: VERIFIED FIXED

(Thunderbird :: Address Book, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot1: Overlong input fields for First/Last name (Japanese with extra phonetic fields)

(Followup from Bug 1652256 Comment 44)
(Richard?)

STR

1. Japanese localization, mail.addr_book.show_phonetic_fields="true"
2. Create a new contact from AB
3. Look at size of First/Last inputs, and the overall proportions of inputs in this dialog.

Actual Result

The left item column is abnormally long.

• First/Last input fields look too long, causing the entire dialog to go out of proportion, esp. with extra column for phonetic fields.

Expected

• Reduce width of First/Last input fields (esp. with mail.addr_book.show_phonetic_fields="true")

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Normal-width.png

I don't know why your dialog is so wide. This is how my dialog looks -> no problem.

Comment 2

[Alessandro Castellani [:aleca]]

Mine looks correct as well, also the vCard dialog in the account settings looks fixed

Comment 3

[Alessandro Castellani [:aleca]]

Probably this was fixed by bug 1652256, which hasn't landed on 78 yet and it's scheduled for 78.1.1
I'm pinging the original reporter also here with a link to the current beta in case he can test it to confirm it.
https://www.thunderbird.net/en-US/thunderbird/beta/all/

Comment 4

[bvs7033]

Attachment: adNewCardDialog.jpg

I was looking at Bug 1652256 because I have the same symptoms as r1a_w5lz.
I tried it with Thunderbird version 79 beta3thunderbirdnightly 81.0a1.en.win64.
The symptoms have not improved.

OS　 Windows 10 64bit 1909 build 18363.959
GPU ASUS GTX1070 GAMING 8G
CPU intel Core i7-7700K Box 1151
Display ASUS VZ249HR-J
Motherboard ASUS ROG MAXIMUS IX HERO Z270 LGA1151
Memory CORSAIR CMK16GX4M2A2666C16R DDR4-2666 8GB×2
SSD Intel 760p SSDPEKKW256G8XT M.2 PCIEx4 256GB

Comment 5

[bvs7033]

Attachment: adNewCardDialog.jpg

I apologizes
The machine translation is wrong and I will repost it.

I have the same abNewCardDialog bug as r1a_w5lz.
That's why I've been looking at Bug1652256 until now.
Once again, Thunderbird 79 beta3 ja and
thunderbird-81.0a1.ja.win64.installer.exe 28-Jul-2020 12:52
We have checked.
But the symptoms have not improved. The problem continues.
Like r1a_w5lz, the left side is too long.
The entire dialog is also too wide.

OS:Windows 10 64bit 1909 build 18363.959.
GPU:ASUS GTX1070 GAMING 8G.
CPU:Intel Core i7-7700K.
Display:ASUS VZ249HR-J.
Motherboard:ASUS ROG MAXIMUS IX HERO Z270.
Memory:CORSAIR CMK16GX4M2A2666C16R DDR4-2666.
SSD:Intel 760p SSDPEKKW256G8XT M.2.

Comment 6

[ISHIKAWA, Chiaki]

Attachment: new-contact-under-windows10-64-bit-pro-Japanese-locale-image.png

(In reply to Richard Marti (:Paenglab) from comment #1)

Created attachment 9166637 [details]
Normal-width.png

I don't know why your dialog is so wide. This is how my dialog looks -> no problem.

Can someone enlighten me why there are different layouts even on the same system (windows 10, linux, etc.) as seen by many reporters?

For example, the attached figure is my dialog for new contact under windows 10 pro (64-bit) with TB 78.0.1 (32-bit).
I see the layout of boxes with labels differ quite a bit under the red horizontal line I drew.

Also, I was a bit puzzled why I did not see the Bug 1652256 under windows 10 pro (64-bit) and I use Japanese locale.

I am just curious and some may think such information is tangential to the issue here, but that information would be necessary to create a meaningful test (although I have no idea how you are going to measure the size of boxes from within, say, mochitest test program.)

I hope such different layouts are not caused by some uninitialized memory values that chose some layout algorithmic paths randomly.

Comment 7

[Ping Chen [:rnons] (away)]

Attachment: 1655816.patch

This patch sets the same max-width to name and phonetic inputs. It's most common in Japan to see phonetic input has the same width as name input.

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9166788 [details] [diff] [review]
1655816.patch

Looks good, thanks. I hope this helps the ones that see the wide textfields.

Comment 9

[Ping Chen [:rnons] (away)]

I can't edit this bug to add checkin-needed-tb tag, please do it for me, thanks.

Comment 10

[Richard Marti (:Paenglab)]

Can you ask for uplifts too?

Comment 11

[Ping Chen [:rnons] (away)]

Comment on attachment 9166788 [details] [diff] [review]
1655816.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1652256
User impact if declined: the left column of abNewCardDialog is too wide
Testing completed (on c-c, etc.): manually tested
Risk to taking this patch (and alternatives if risky): only affects a few locales with `show_phonetic_fields` set

Comment 12

[Thomas D. (:thomas8)]

(In reply to ISHIKAWA, Chiaki from comment #6)

Can someone enlighten me why there are different layouts even on the same system (windows 10, linux, etc.) as seen by many reporters?

Good question. Maybe you should file a bug to investigate that.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6ce0972429b8
Set max-width to name and phonetic input in abCard dialog. r=Paenglab

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9166788 [details] [diff] [review]
1655816.patch

Approved for beta

Comment 16

[u665984]

Attachment: 81.0a1 30-Jul-2020.jpg

I am the bug reporter.
We have confirmed that the bug has been fixed in this version.
thank you for helping me.
Thank you very much.

thunderbird-81.0a1.ja.win64.zip 77M 30-Jul-2020 13:13

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 80.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/779653d2713b

Comment 19

[Wayne Mery (:wsmwk)]

v.fixed per comment 16

Comment 20

[Wayne Mery (:wsmwk)]

Comment on attachment 9166788 [details] [diff] [review]
1655816.patch

[Triage Comment]
Approved for esr78

Comment 21

[Rob Lemley [:rjl]]

Thunderbird 78.1.1:
https://hg.mozilla.org/releases/comm-esr78/rev/1cc6ac2c9be7