Closed Bug 1655824 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24786 - [FlexNG] Flex items can't be relayout roots, even with `contain`

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24786 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24786
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[FlexNG] Flex items can't be relayout roots, even with contain

When a flex item is a relayout root, it gets neither the flexed nor
stretched dimensions from the parent flexbox. Though this problem seems
to manifest only when the flex item is a legacy layout node.

This change causes a 5% regression in the change-text-css-contain perf
test, even though it doesn't use flex, probably just because we test for
flex-item before deciding that a node with contain: layout size can be
a layout root.

Bug: 1108675

Change-Id: Iec0d35557ebfbf3136bd66fe986ba2456e0d92ab
Reviewed-on: https://chromium-review.googlesource.com/2322074
WPT-Export-Revision: 81ff69c7ecdabb6abe8b3d05f5e63f6ef655d598

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60041bb3184b
[wpt PR 24786] - [FlexNG] Flex items can't be relayout roots, even with `contain`, a=testonly

https://hg.mozilla.org/mozilla-central/rev/60041bb3184b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.