1655915 - Memory leak with video playback over extended periods of time.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Joel Olsson]

After updating geckoview from v76 to v79, our digital signage application (which is a long running application that plays videos/images in a loop) is leaking memory and crashing.

We have tested the application playing just images, and no memory leak is observed. When playing videos, memory usage slowly grows over time, even though we remove videos as per the standard: https://stackoverflow.com/a/28060352/2393941 - On a low memory device, this causes the application to crash within 5-6 hours of constant video playback.

Just to note, this was/is not an issue in the previous version (v76) of geckoview.
We wanted to upgrade to v79 to take advantage of this fix: https://bugzilla.mozilla.org/show_bug.cgi?id=1640369

The reported fatal error was:
"Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1)"
Unfortunately I don't have a complete logcat output at the moment.

Comment 1

[Alastor Wu [:alwu]]

From the description, it seems related with Android media playback. NI John, who is our expert on Android, to see if he has any idea.

Comment 2

[Alastor Wu [:alwu]]

Sorry, an accident.

Comment 3

[Randall Barker [:rbarker]]

FxR has seen an increase in OOMs in v11 which is using GeckoView 79 beta. I wonder if this issue might be related since people tend to use FxR for watching video.

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1655915 - p1: properly release surface. r?snorp

Comment 5

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1655915 - p2: correctly obtain/dispose samples. r?snorp

All samples must be obtained and disposed to make sure they are
recycled instead of leaked.

Depends on D89530

Comment 6

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1655915 - p3: make AndroidSharedBlitGL unique. r?snorp

AndroidSharedBlitGL is never shared with other objects and doesn't
have to be ref-counted.

Depends on D89531

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4faae0e062d
p1: properly release surface. r=snorp,geckoview-reviewers
https://hg.mozilla.org/integration/autoland/rev/9393f2995a02
p2: correctly obtain/dispose samples. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/76fa65eaec54
p3: make AndroidSharedBlitGL unique. r=jgilbert

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d4faae0e062d
https://hg.mozilla.org/mozilla-central/rev/9393f2995a02
https://hg.mozilla.org/mozilla-central/rev/76fa65eaec54