1655999 - The devtools.performance.recording.ui-base-url pref rejects "netlify.app" deploy preview URLs

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Markus Stange [:mstange]]

This regex currently only allows netlify.com:

https://searchfox.org/mozilla-central/rev/d9f92154813fbd4a528453c33886dc3a74f27abb/devtools/startup/DevToolsStartup.jsm#286

      // Allows the following:
      //   "https://deploy-preview-1234--perf-html.netlify.com"
      //   "https://deploy-preview-1234--perf-html.netlify.com/"
      //   "https://deploy-preview-1234567--perf-html.netlify.com"
      /^https:\/\/deploy-preview-\d+--perf-html\.netlify\.com\/?$/.test(
        targetUrl
      )
    ) {

But netlify encourages using netlify.app these days.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1655999 - Support netlify.app URLs for the profiler frontend code deploy previews r=canaltinova!

Netlify recently moved from netlify.com to netlify.app for their
deployed URLs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62d7b5de50e5
Support netlify.app URLs for the profiler frontend code deploy previews r=canaltinova

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 9166857 [details]
Bug 1655999 - Support netlify.app URLs for the profiler frontend code deploy previews r=canaltinova!

Beta/Release Uplift Approval Request

• User impact if declined: It's not possible to test profiler frontend's new code with the beta channel.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is not risky because this code isn't used by end-users but rather gecko developers. Moreover this is used when the user changes about:config, so this is really for advanced developers.
• String changes made/needed:

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9166857 [details]
Bug 1655999 - Support netlify.app URLs for the profiler frontend code deploy previews r=canaltinova!

approved for 80.0b2

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/62d7b5de50e5

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a588d1680a8e