1656009 - Case sensitivity check box set on a non-case sensitive search

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Andrew McCreight [:mccr8]]

1. Do a search with case sensitivity explicitly set: https://searchfox.org/mozilla-central/search?q=minidumps&case=true&path=
2. Do a search without case sensitivity explicitly set: https://searchfox.org/mozilla-central/search?q=minidumps&path=

In the results for the second search, the "case sensitivity" check box is set, but the search is not actually case sensitive. (FWIW, I prefer the case sensitivity value not being remembered, for the way I use SearchFox.)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I think the preferred behaviour here is:

• the localstorage value of caseSensitive should only change if the user actually clicks on the checkbox
• the checkbox display should reflect the URL when loading a URL, or show the value from localstorage otherwise

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://github.com/mozsearch/mozsearch/pull/366

Comment 3

[Andrew McCreight [:mccr8]]

Thanks for the fix!

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Thanks for providing STR! (I think smaug had complained about this issue previously but without details)