1656014 - can not use WebDriverExtensionCommand as a dyn type because of PartialEq - webdriver crate

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P1)

Description

[whizsid]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36

Steps to reproduce:

I am from this PR. This crate is using the webdriver crate. As per the discussion of this PR I want to use the WebDriverExtensionCommand as a Box<dyn WebDriverExtensionCommand>.

Actual results:

pub trait WebDriverExtensionCommand : Send + Clone + PartialEq{}
| --- --------- ...because it uses Self as a type parameter in this
| |
| this trait cannot be made into an object...

Expected results:

Using the WebDriverExtensionCommand as a dyn type.

Comment 1

[Daniel Veditz [:dveditz]]

Did you mean to mark this as a security bug? That keeps the Marionette folks from seeing it, and the security team isn't really sure what to do with this.

Comment 2

[whizsid]

(In reply to Daniel Veditz [:dveditz] from comment #1)

Did you mean to mark this as a security bug? That keeps the Marionette folks from seeing it, and the security team isn't really sure what to do with this.

Sorry! It is not a security bug. I accidentally ticked it. But I can not edit it again.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

James, could you please have a look what's wrong here? Is that a limitation on our side?

Comment 4

[James Graham [:jgraham]]

Attachment: Bug 1656014 - Remove PartialEq bound on WebDriverExtensionCommand,

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7f08d3e2848
Remove PartialEq bound on WebDriverExtensionCommand, r=webdriver-reviewers,whimboo

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d7f08d3e2848