1656018 - Update tests should use AppInfo to generate mock application info objects

Status: RESOLVED FIXED

(Toolkit :: Application Update, task)

Description

[Dave Townsend [:mossop]]

I think the update code is the only place remaining that creates its own appinfo objects meaning that it is missing a couple of things that other components expect to exist. We should switch to using AppInfo.jsm like everything else.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1656018: Switch the update service tests to use AppInfo.jsm. r=mhowell!

This uses AppInfo to generate the mock appinfo objects rather than rolling our
own so we can share improvements to that with the rest of the tree.

The mock appinfo used for setUpdateURL also doesn't expose various properties
that may be expected to exist. We can't use AppInfo here as we dynamically
replace Services.appinfo in browser-chrome tests. Instead this makes the mock
appinfo object use the real object as a prototype replacing only the updateURL
property.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf5eb7674c05
Switch the update service tests to use AppInfo.jsm. r=mhowell

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/cf5eb7674c05