1656023 - The contents of an inline PGP encrypted message aren't shown, if it has a bad signature

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Christian Riechers]

TB79.0 beta3, Linux

A plain text, inline PGP encrypted list message from one particular sender stills fails to decrypt. I.e. after pressing the 'Decrypt' button, the cipher text is still there.

The Error Console has this:
Uncaught (in promise) Error: unhandled partial PGP message with bad signature
updateHdrIcons chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js:336
messageParseCallback chrome://openpgp/content/ui/enigmailMessengerOverlay.js:1486
messageParse chrome://openpgp/content/ui/enigmailMessengerOverlay.js:1278
messageDecryptCb chrome://openpgp/content/ui/enigmailMessengerOverlay.js:1021
messageDecrypt chrome://openpgp/content/ui/enigmailMessengerOverlay.js:719
onData chrome://openpgp/content/modules/mime.jsm:459
onStopRequest chrome://openpgp/content/modules/streams.jsm:78
callbackWrapper chrome://openpgp/content/modules/timer.jsm:30
notify resource://gre/modules/Timer.jsm:62
enigmailMsgHdrViewOverlay.js:336:13

Comment 1

[Kai Engert [:KaiE:]]

Can you please set environment variable RNP_LOG_CONSOLE=1 and start Thunderbird from that console?
Do you get log output from the RNP library?

Lines from RNP contain the text "home/user/github/rnp/src/" for example like this:
[signature_validate() /home/user/github/rnp/src/lib/crypto/signatures.cpp:214] wrong lbits
[signature_check() /home/user/github/rnp/src/librepgp/stream-sig.cpp:1051] invalid or untrusted key

Comment 2

[Christian Riechers]

Here's the log output:
[signature_parse_subpacket() /builds/worker/checkouts/gecko/comm/third_party/rnp/src/librepgp/stream-packet.cpp:1460] unknown subpacket : 38
[signature_parse_subpacket() /builds/worker/checkouts/gecko/comm/third_party/rnp/src/librepgp/stream-packet.cpp:1460] unknown subpacket : 38
[signed_src_finish() /builds/worker/checkouts/gecko/comm/third_party/rnp/src/librepgp/stream-parse.cpp:930] signer's key not found
[signature_check() /builds/worker/checkouts/gecko/comm/third_party/rnp/src/librepgp/stream-sig.cpp:1051] invalid or untrusted key
[signature_parse_subpacket() /builds/worker/checkouts/gecko/comm/third_party/rnp/src/librepgp/stream-packet.cpp:1460] unknown subpacket : 38
[signature_parse_subpacket() /builds/worker/checkouts/gecko/comm/third_party/rnp/src/librepgp/stream-packet.cpp:1460] unknown subpacket : 38

Comment 3

[Kai Engert [:KaiE:]]

Thanks for the log output.
We have two different problems here.

Comment 4

[Kai Engert [:KaiE:]]

Problem 1 is caused by the message containing packets that RNP doesn't like.

Subpacket 38 isn't defined in RFC 4880, so apparently there is a nonstandard key involved.

Nickolay, do you think RNP might return an error message (or bad signature status) if it discovers a non-critical 38 ?
Or, because we see a non-success status, can we conclude that the packet 38 is defined as critical by the message?

Comment 5

[Kai Engert [:KaiE:]]

Problem 2 is with Thunderbird code.

If we detect a bad signature error code, for a message that was identified as inline with surrounding text (partial openpgp), then currently we throw an exception and stop processing.

I'll create a patch that will avoid that exception, and will continue to process the message.

Comment 6

[Kai Engert [:KaiE:]]

Attachment: Bug 1656023 - Don't abort processing of inline decrypted messages with bad signature. r=PatrickBrunschwig

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/201a22f8e6ac
Don't abort processing of inline decrypted messages with bad signature. r=PatrickBrunschwig DONTBUILD

Comment 8

[Kai Engert [:KaiE:]]

Comment on attachment 9168019 [details]
Bug 1656023 - Don't abort processing of inline decrypted messages with bad signature. r=PatrickBrunschwig

OpenPGP correctness fix. Only affects messages that were previously displayed incorrectly.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9168019 [details]
Bug 1656023 - Don't abort processing of inline decrypted messages with bad signature. r=PatrickBrunschwig

[Triage Comment]
Approved for beta

Comment 10

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-beta/rev/c366c93bbf90f68049c42e84414627fc2263db13

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9168019 [details]
Bug 1656023 - Don't abort processing of inline decrypted messages with bad signature. r=PatrickBrunschwig

[Triage Comment]
Approved for esr78

Comment 12

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-esr78/rev/19caba86ee5fbfac7e4298ba62d9b5974a6c05a3