1656126 - Remove or update probes expiring in Firefox 82: devtools.main.close_source_tab#close_source_tab

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 82 [1].

devtools.main.close_source_tab#close_source_tab

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #fx-metrics Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Julian Descottes [:jdescottes]]

This was added by Bug 1647346, but we didn't perform any analysis of the data.
The idea was to help us decide what to do with Bug 1640604.

Tim: is there any way to retrieve the collected data for this event which expired in 82?
In any case I guess I'm going to remove the code, but if we have some answers to the questions asked in Bug 1640604 we might as well collect them now before we forget about this :)

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1656126 - [devtools] Remove expired event devtools.main.close_source_tab#close_source_tab

Comment 3

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Tim: is there any way to retrieve the collected data for this event which expired in 82?

Yes! Opening a ticket in the Jira DO project is probably the best way to proceed: https://jira.mozilla.com/projects/DO/issues/

We still have the data and can report on what we saw.

Comment 4

[Julian Descottes [:jdescottes]]

(In reply to Tim Smith 👨‍🔬 [:tdsmith] from comment #3)

Tim: is there any way to retrieve the collected data for this event which expired in 82?

Yes! Opening a ticket in the Jira DO project is probably the best way to proceed: https://jira.mozilla.com/projects/DO/issues/

We still have the data and can report on what we saw.

Thanks! I tried to file an issue at https://jira.mozilla.com/projects/DO/issues/DO-480

Let me know if anything's missing in there!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ee544ed2f38
[devtools] Remove expired event devtools.main.close_source_tab#close_source_tab r=Honza

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1ee544ed2f38

Comment 7

[Julian Descottes [:jdescottes]]

(In reply to Julian Descottes [:jdescottes] from comment #4)

(In reply to Tim Smith 👨‍🔬 [:tdsmith] from comment #3)

Tim: is there any way to retrieve the collected data for this event which expired in 82?

Yes! Opening a ticket in the Jira DO project is probably the best way to proceed: https://jira.mozilla.com/projects/DO/issues/

We still have the data and can report on what we saw.

Thanks! I tried to file an issue at https://jira.mozilla.com/projects/DO/issues/DO-480

Let me know if anything's missing in there!

As mentioned on the ticket, the event was not properly implemented. It was passing a session_id key (which is passed by default for all devtools telemetry events), but this was not declared in Events.yaml. This made telemetry reject all events. This event landed without any test and was obviously not manually tested either.

There's no usable data to analyze.