1656140 - WebExtensions tests failing on debug: browser_ext_windows.js, browser_ext_tabs_events.js, etc.

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=311450426&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/K-Spw6PqQk2eyWsQu--hNQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1656140-webext-tests-focus-1.diff

Some of these tests have always had problems with the main window's focus, especially since we hid the folder tree by default for some reason. I've used a variety of hacks to mitigate this, all of which I'm removing here, and replacing it with Services.focus.focusedWindow = window, which seems to work.

There's some failures I've never seen before on the Try run, but they went away on a retrigger, so I'm hoping it's just intermittent weirdness. Unrelated to this patch in any case.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9166963 [details] [diff] [review]
1656140-webext-tests-focus-1.diff

Review of attachment 9166963 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and looks like a nicer way to handle this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/106e9ab1abc4
Stop WebExtensions tests timing out at completion. r=pmorris

Comment 4

[Intermittent Failures Robot]

16 failures in 4289 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 16

Platform breakdown:

• linux64: 4
• windows10-64: 4
• macosx1014-64: 4
• windows7-32: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1656140&startday=2020-07-27&endday=2020-08-02&tree=all

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9166963 [details] [diff] [review]
1656140-webext-tests-focus-1.diff

This is only test code. Bug 1655892 exposed these failing tests.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9166963 [details] [diff] [review]
1656140-webext-tests-focus-1.diff

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/eaacfcc60f26

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9166963 [details] [diff] [review]
1656140-webext-tests-focus-1.diff

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/92755103ac8b