Closed Bug 1656148 Opened 2 years ago Closed 2 years ago

Fix more linter "no-undef" errors

Categories

(Thunderbird :: General, task)

Thunderbird 81

Tracking

(thunderbird_esr78 fixed, thunderbird80 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr78 --- fixed
thunderbird80 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(2 files)

Another bunch of no-undef errors have appeared. The variables aren't undefined at all, but they've only been imported second-hand (ie. A imports globals from B which imports globals from C where the variable is defined). This is confusing the linter, probably because it's now multi-process.

I'm using globals instead of import-globals-from for ComposerCommands.js to make it easier to identify what is actually imported from that file. Not a lot, it turns out.

Target Milestone: --- → 81 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7b8c28dc874a
Fix more linter "no-undef" errors and remove some dead compose code. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Ah whoops, I caused an error. I'd seen it but not realised it was my fault.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Fixes two errors that happen when the compose window is opened:
TypeError: can't redefine non-configurable property "FileUtils"
ReferenceError: XPCOMUtils is not defined

I caused the first with the previous commit in this bug – this patch undoes part of it. I don't know where the second came from.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3013914e29e0
follow-up - Fix errors on compose window opening. r=kaie DONTBUILD

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Version: unspecified → Thunderbird 81

Comment on attachment 9166966 [details]
Bug 1656148 - Fix more linter "no-undef" errors and remove some dead compose code. r?pmorris

[Triage Comment]
Fixes linting errors on comm-beta.

Attachment #9166966 - Flags: approval-comm-beta+

Comment on attachment 9166966 [details]
Bug 1656148 - Fix more linter "no-undef" errors and remove some dead compose code. r?pmorris

[Triage Comment]
With the various uplifts to esr78, this is now needed to clear up eslint errors.

Attachment #9166966 - Flags: approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.