1656148 - Fix more linter "no-undef" errors

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan)]

Another bunch of no-undef errors have appeared. The variables aren't undefined at all, but they've only been imported second-hand (ie. A imports globals from B which imports globals from C where the variable is defined). This is confusing the linter, probably because it's now multi-process.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1656148 - Fix more linter "no-undef" errors and remove some dead compose code. r?pmorris

I'm using globals instead of import-globals-from for ComposerCommands.js to make it easier to identify what is actually imported from that file. Not a lot, it turns out.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7b8c28dc874a
Fix more linter "no-undef" errors and remove some dead compose code. r=pmorris

Comment 3

[Geoff Lankow (:darktrojan)]

Ah whoops, I caused an error. I'd seen it but not realised it was my fault.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1656148 follow-up - Fix errors on compose window opening. r?kaie

Fixes two errors that happen when the compose window is opened:
TypeError: can't redefine non-configurable property "FileUtils"
ReferenceError: XPCOMUtils is not defined

I caused the first with the previous commit in this bug – this patch undoes part of it. I don't know where the second came from.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3013914e29e0
follow-up - Fix errors on compose window opening. r=kaie DONTBUILD

Comment 6

[Intermittent Failures Robot]

2 failures in 4289 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform breakdown:

• lint: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1656148&startday=2020-07-27&endday=2020-08-02&tree=all

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9166966 [details]
Bug 1656148 - Fix more linter "no-undef" errors and remove some dead compose code. r?pmorris

[Triage Comment]
Fixes linting errors on comm-beta.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/5fa744a6bfcb
https://hg.mozilla.org/releases/comm-beta/rev/5e0201d82efd

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9166966 [details]
Bug 1656148 - Fix more linter "no-undef" errors and remove some dead compose code. r?pmorris

[Triage Comment]
With the various uplifts to esr78, this is now needed to clear up eslint errors.

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/06a2dc069e70
https://hg.mozilla.org/releases/comm-esr78/rev/b479b2985a92