1656237 - Find > Search Messages - no right click context menu option to paste

Status: VERIFIED FIXED

(Thunderbird :: Search, defect)

Description

[Anje]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Windows 10
Thunderbird 78.0.1
Highlighted an email address in messages; used right click and selected 'copy' or 'copy email address'.
Menu app icon > Find > Search Messages
From > contains > right click in text area to select paste

Actual results:

There is no options offered if right click.
Cannot select eg: 'Paste'

Ctrl + V works

Expected results:

Expected a pop up option list with 'Undo', 'Cut', 'Copy', Paste', 'Delete' and 'Select All' as options. As nothing is currently in the text box, 'Paste' should have been the only one not greyed out and able to select.

Comment 1

[Anje]

Problem also reported by someone in support forum, they were using 78.0.1
https://support.mozilla.org/en-US/questions/1296781

Comment 2

[Magnus Melin [:mkmelin]]

Fallout from the xul:textbox -> html:input conversions.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1656237_search_input_context.patch

Comment 4

[Khushil Mistry [:khushil324]]

Comment on attachment 9168371 [details] [diff] [review]
bug1656237_search_input_context.patch

Review of attachment 9168371 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=khushil

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58687aac6efc
Find > Search Messages - make the fields get a copy/paste etc. context menu. r=khushil

Comment 6

[Jorg K (CEST = GMT+2)]

Sadly uplift request was forgotten here.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9168371 [details] [diff] [review]
bug1656237_search_input_context.patch

Not forgotten, but it only landed on trunk 4 days ago.

[Triage Comment]
Safe one-liner, caused by the xul:textbox removals.

Comment 8

[Jorg K (CEST = GMT+2)]

OK, please let me know after what time it can be classified as "forgotten". So bug 1655286 and bug 1655279 were also not forgotten although they missed a beta release? Please make sure to file the requests before Wayne comes around and does the approvals for the next release. We're especially talking about regression fixes.

EDIT: What is the point of the administrative overhead? The person doing the approvals (Wayne) will asses the risk and wait with the approval if he wants to see it longer on trunk. He also knows the release schedule, so even if he approves (too) early, there it the chance to cancel the approval later. Especially adding the forgotten <script src="chrome://global/content/editMenuOverlay.js"/> line which we have done a dozen of times before really doesn't need any exposure on trunk.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9168371 [details] [diff] [review]
bug1656237_search_input_context.patch

[Triage Comment]
Approved for beta

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9168371 [details] [diff] [review]
bug1656237_search_input_context.patch

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 80.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/4a95fe2b53eb

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/8efed3657af3

Comment 13

[WaltS48 [:walts48]]

Working in TB 80.0b4 on Ubuntu 18.04.4 LTS Linux for me.