Closed Bug 1656280 Opened 10 months ago Closed 7 months ago

Enable ESLint no-unused-vars and no-undef rules on widget/test/*.xhtml files

Categories

(Core :: Widget, task, P3)

Product:
Core
Component:
Widget
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: standard8, Assigned: soniasingla.1812)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=standard8
47 bytes, text/x-phabricator-request
Details | Review

When we moved xul files to xhtml we disabled various ESLint rules by default where they were failing.

This bug is to enable no-unused-vars and no-undef on widget/test/*.xhtml files

https://searchfox.org/mozilla-central/rev/56bb74ea8e04bdac57c33cbe9b54d889b9262ade/.eslintrc.js#532,535

This bug is to enable those rules.

No longer depends on: 1656011
Summary: Enable no-unused-vars and no-undef on widget/test/*.xhtml files → Enable ESLint no-unused-vars and no-undef rules on widget/test/*.xhtml files
Blocks: 1669724
Attachment #9169044 - Attachment description: Bug 1656280 - Enable ESLint no-unused-vars and no-undef rules on widget/test/*.xhtml files. r=standard8 → Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=standard8
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebe1566cf389
Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell

https://hg.mozilla.org/mozilla-central/rev/ebe1566cf389

Status: NEW → RESOLVED
Closed: 7 months ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Thank you Sonia.

You need to log in before you can comment on or make changes to this bug.