Closed
Bug 1656289
Opened 4 years ago
Closed 4 years ago
Enable EME for GeckoView
Categories
(GeckoView :: General, defect)
Tracking
(firefox80 fixed, firefox81 fixed)
RESOLVED
FIXED
81 Branch
People
(Reporter: rbarker, Assigned: rbarker)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fxr:p1])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
The recent patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1652474 actually disabled EME on all platform instead of enabling it due to the face that XP_LINUX is true of android builds.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → rbarker
Status: NEW → ASSIGNED
Assignee | ||
Updated•4 years ago
|
Whiteboard: [fxr:p1]
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Has Regression Range: --- → yes
Keywords: regression
Pushed by rbarker@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a7d95ea90f1 Enable EME for all GeckoView builds. r=jolin
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Comment 4•4 years ago
|
||
Please nominate this for Beta approval when you get a chance.
Flags: needinfo?(rbarker)
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9167072 [details]
Bug 1656289 - Enable EME for all GeckoView builds.
Beta/Release Uplift Approval Request
- User impact if declined: Users will not be able to play EME protected media.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This change enables a feature for all release channels than has been enabled in nightly for quite some time at this point.
- String changes made/needed: none
Flags: needinfo?(rbarker)
Attachment #9167072 -
Flags: approval-mozilla-beta?
Comment 6•4 years ago
|
||
Comment on attachment 9167072 [details]
Bug 1656289 - Enable EME for all GeckoView builds.
Fixes the logic to the intended state from bug 1652474. Approved for 80.0b7.
Attachment #9167072 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•4 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•