1656289 - Enable EME for GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Randall Barker [:rbarker]]

The recent patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1652474 actually disabled EME on all platform instead of enabling it due to the face that XP_LINUX is true of android builds.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1656289 - Enable EME for all GeckoView builds.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a7d95ea90f1
Enable EME for all GeckoView builds. r=jolin

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0a7d95ea90f1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 5

[Randall Barker [:rbarker]]

Comment on attachment 9167072 [details]
Bug 1656289 - Enable EME for all GeckoView builds.

Beta/Release Uplift Approval Request

• User impact if declined: Users will not be able to play EME protected media.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change enables a feature for all release channels than has been enabled in nightly for quite some time at this point.
• String changes made/needed: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9167072 [details]
Bug 1656289 - Enable EME for all GeckoView builds.

Fixes the logic to the intended state from bug 1652474. Approved for 80.0b7.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d0a0af1b399a