1656291 - Enable all ESLint rules on toolkit/**/*.xhtml files

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

When we moved xul files to xhtml we disabled various ESLint rules by default where they were failing.

This bug is to enable no-unused-vars and no-undef on toolkit/**/*.xhtml files

https://searchfox.org/mozilla-central/rev/56bb74ea8e04bdac57c33cbe9b54d889b9262ade/.eslintrc.js#755,757

This bug is to enable those rules.

Note: we'll need to understand why SimpleTest/info/ok etc are not defined on some of the tests by default. It could be that they're being loaded into other files that define those globals in the scope automatically.

Comment 1

[Sonia Singla :soniasingla]

Attachment: Bug 1656291 - Enable all ESLint rules for toolkit/components/aboutmemory/tests/*.xhtml. r=standard8

Comment 2

[Sonia Singla :soniasingla]

Attachment: Bug 1656291 - Enable all ESLint rules on xhtml test files in toolkit/components/{ctypes|osfile|places|workerloader}

Depends on D85626

Comment 3

[Sonia Singla :soniasingla]

Attachment: Bug 1656291 - Enable all ESLint rules for some files in toolkit/content/tests/chrome/. r=standard8

Depends on D85627

Comment 4

[Sonia Singla :soniasingla]

Attachment: Bug 1656291 - Enable all ESLint rules for some more xhtml files in toolkit/content/tests/chrome/. r=standard8

Depends on D86483

Comment 5

[Sonia Singla :soniasingla]

Attachment: Bug 1656291 - Enable all ESLint rules for remaining xhtml files in toolkit/content/tests/chrome/. r=standard8

Depends on D87183

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6d0df9d4e44
Enable all ESLint rules for toolkit/components/aboutmemory/tests/*.xhtml. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/e24882c66cc9
Enable all ESLint rules on xhtml test files in toolkit/components/{ctypes|osfile|places|workerloader} r=Standard8
https://hg.mozilla.org/integration/autoland/rev/ff32ec1091bf
Enable all ESLint rules for some files in toolkit/content/tests/chrome/. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/e3df31c1cbe7
Enable all ESLint rules for some more xhtml files in toolkit/content/tests/chrome/. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/e28fa0b7c013
Enable all ESLint rules for remaining xhtml files in toolkit/content/tests/chrome/. r=Standard8

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d6d0df9d4e44
https://hg.mozilla.org/mozilla-central/rev/e24882c66cc9
https://hg.mozilla.org/mozilla-central/rev/ff32ec1091bf
https://hg.mozilla.org/mozilla-central/rev/e3df31c1cbe7
https://hg.mozilla.org/mozilla-central/rev/e28fa0b7c013