Closed Bug 1656291 Opened 2 months ago Closed 19 days ago

Enable all ESLint rules on toolkit/**/*.xhtml files

Categories

(Toolkit :: General, task, P3)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: standard8, Assigned: soniasingla.1812)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

When we moved xul files to xhtml we disabled various ESLint rules by default where they were failing.

This bug is to enable no-unused-vars and no-undef on toolkit/**/*.xhtml files

https://searchfox.org/mozilla-central/rev/56bb74ea8e04bdac57c33cbe9b54d889b9262ade/.eslintrc.js#755,757

This bug is to enable those rules.

Note: we'll need to understand why SimpleTest/info/ok etc are not defined on some of the tests by default. It could be that they're being loaded into other files that define those globals in the scope automatically.

Summary: Enable no-unused-vars and no-undef on toolkit/**/*.xhtml files → Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files
Assignee: nobody → soniasingla.1812
Status: NEW → ASSIGNED
Attachment #9169039 - Attachment description: Bug 1656291 - Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files. r=mossop → Bug 1656291 - Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files. r=standard8
Attachment #9167407 - Attachment description: Bug 1656291 - Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files. r=standard8 → Bug 1656291 - Enable all ESLint rules on xhtml test files in toolkit/components/{ctypes|osfile|places|workerloader}
Attachment #9167405 - Attachment description: Bug 1656291 - Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files. r=standard8 → Bug 1656291 - Enable all ESLint rules for toolkit/components/aboutmemory/tests/*.xhtml. r=standard8
Attachment #9169039 - Attachment description: Bug 1656291 - Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files. r=standard8 → Bug 1656291 - Enable all ESLint rules for some files in toolkit/content/tests/chrome/. r=standard8
Attachment #9170204 - Attachment description: Bug 1656291 - Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files. r=standard8 → Bug 1656291 - Enable all ESLint rules for some more xhtml files in toolkit/content/tests/chrome/. r=standard8
Summary: Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files → Enable all ESLint rules on toolkit/**/*.xhtml files
Attachment #9171546 - Attachment description: Bug 1656291 - Enable ESLint no-unused-vars and no-undef rules on toolkit/**/*.xhtml files. r=standard8 → Bug 1656291 - Enable all ESLint rules for remaining xhtml files in toolkit/content/tests/chrome/. r=standard8
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6d0df9d4e44
Enable all ESLint rules for toolkit/components/aboutmemory/tests/*.xhtml. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/e24882c66cc9
Enable all ESLint rules on xhtml test files in toolkit/components/{ctypes|osfile|places|workerloader} r=Standard8
https://hg.mozilla.org/integration/autoland/rev/ff32ec1091bf
Enable all ESLint rules for some files in toolkit/content/tests/chrome/. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/e3df31c1cbe7
Enable all ESLint rules for some more xhtml files in toolkit/content/tests/chrome/. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/e28fa0b7c013
Enable all ESLint rules for remaining xhtml files in toolkit/content/tests/chrome/. r=Standard8
You need to log in before you can comment on or make changes to this bug.