Closed Bug 1656293 Opened 2 years ago Closed 1 year ago

Enable ESLint no-unused-vars rules on docshell/test/chrome/*.xhtml files

Categories

(Core :: DOM: Navigation, task, P3)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: standard8, Assigned: soniasingla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When we moved xul files to xhtml we disabled various ESLint rules by default where they were failing.

This bug is to enable no-unused-vars and no-undef on docshell/test/chrome/*.xhtml files.

https://searchfox.org/mozilla-central/rev/56bb74ea8e04bdac57c33cbe9b54d889b9262ade/.eslintrc.js#463-464

Summary: Enable ESLint no-undef and no-unused-vars on docshell/test/chrome/*.xhtml files → Enable ESLint no-undef and no-unused-vars rules on docshell/test/chrome/*.xhtml files

P3

Priority: -- → P3
Assignee: nobody → soniasingla.1812
Status: NEW → ASSIGNED
Attachment #9194673 - Attachment description: Bug 1656293 - Enable ESLint no-undef and no-unused-vars rules on docshell/test/chrome/*.xhtml files. r=standard8 → Bug 1656293 - Enable ESLint no-unused-vars rules on docshell/test/chrome/*.xhtml files. r=standard8

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:soniasingla.1812, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(soniasingla.1812)
Summary: Enable ESLint no-undef and no-unused-vars rules on docshell/test/chrome/*.xhtml files → Enable ESLint no-unused-vars rules on docshell/test/chrome/*.xhtml files
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87634810645d
Enable ESLint no-unused-vars rules on docshell/test/chrome/*.xhtml files. r=nika
Flags: needinfo?(soniasingla.1812)
Blocks: 1696873
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.