1656296 - Add an indicator for blocked downloads.

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Sebastian Streich [:sstreich]]

In case we locally decide a download to be insecure/unwanted we should show an an indicator similar to the "potentially malware" download alert and let the user choose how to proceed

Comment 1

[Sebastian Streich [:sstreich]]

Attachment: Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb

---

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b7eb33c8ec9
Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_test_mixed_content_download.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/269b14751fb00398e6f6ca0d0b48904b0739dd7f
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313444104&repo=autoland&lineNumber=15806

Comment 4

[Narcis Beleuzu [:NarcisB]]

Please also check:

1. Xpcshell failure on /test_DownloadLegacy.js -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313444616&repo=autoland&lineNumber=3313
2. BC failure on browser_indicatorDrop.js -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313444727&repo=autoland&lineNumber=3196
3. BC failure on browser_contentAltClick.js -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313444734&repo=autoland&lineNumber=2847
4. BC failure on browser_firstPartyIsolation_saveAs.js -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313444728&repo=autoland&lineNumber=4704

Comment 5

[Sebastian Streich [:sstreich]]

Updated the patch :)
the mentioned tests are now green.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2e2a3ea1e1b6e59e4d0c333d07581eac307a312

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/388c153da388
Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing default process leaks.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=388c153da3880ff42f21767054a183593f5b38af&selectedTaskRun=dRNwqsA_RM-HN6xYfxwshw.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=313471476&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/8e4a5d5847d670aa3efb7b081aa23fb60deb21d6

Comment 8

[Sebastian Streich [:sstreich]]

Sorry! Found the cause of the leak and fixed it.
Try is green now - https://treeherder.mozilla.org/#/jobs?repo=try&revision=451fd2dfd6499709aff9d51cd6c1e09b4caaa005

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4475d1e0186a
Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4475d1e0186a

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f32e30ca400
Port bug 1656296 - New argument to nsITransfer::Init. rs=bustage-fix

Comment 12

[Julien Cristau [:jcristau]]

"save link as..." in the context menu doesn't seem covered by this, is there a bug for that? Nothing happens, not even a message in the console.

Comment 13

[Sebastian Streich [:sstreich]]

Filed Bug 1662138 for that. :)