Closed Bug 1656299 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24816 - [layout] Fix relative positioning w/ percents and calcs.

Categories

(Core :: Layout: Positioned, task, P4)

Product:
Core
Component:
Layout: Positioned
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24816 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24816
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[layout] Fix relative positioning w/ percents and calcs.

Previously we would accidentally resolve things like: "top: 50%" against
"-1" (in the case where we have an indefinite size) causing an incorrect
position.

Additionally there was a separate bug where we'd resolve
"top: calc(10px + 10%)" against indefinite sizes, which also shouldn't
resolve.

This patch fixes both these issues.

Change-Id: I2ec4fa324217225fcdc0dcb3fbd4f55c256829c6

Reviewed-on: https://chromium-review.googlesource.com/2329917
WPT-Export-Revision: bfbf92b714e1b1f98ffbf9032977387e015b9a14

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b17284e3037e
[wpt PR 24816] - [layout] Fix relative positioning w/ percents and calcs., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3842825edffb
[wpt PR 24816] - [layout] Fix relative positioning w/ percents and calcs., a=testonly

https://hg.mozilla.org/mozilla-central/rev/3842825edffb

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.