Closed Bug 1656303 Opened 4 years ago Closed 4 years ago

Unintentional A_SPECIFIC_TARGET warnings being emitted on ./mach build binaries

Categories

(Firefox Build System :: General, defect, P3)

defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox79 unaffected, firefox80 wontfix, firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- wontfix
firefox81 --- fixed

People

(Reporter: kats, Assigned: mhentges)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

When running ./mach build binaries, at this line, what is ['binaries'] rather than 'binaries' (i.e. it's an array of strings, not a string), so the check there always fails. So running ./mach build binaries with a compilation error always emits the A_SPECIFIC_TARGET warning, which I don't think is what is intended.

Woo duck typing!

Assignee: nobody → mhentges
Severity: -- → S3
Priority: -- → P3
No longer blocks: 1651806
Regressed by: 1651806
Has Regression Range: --- → yes

The "what" value contains a list of build targets, the warning should be printed if any one of the targets is unexpected.

Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/50f9d7d57b92 Only print $A_SPECIFIC_TARGET warning if one of the targets is not in the allowlist r=firefox-build-system-reviewers,rstewart
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Set release status flags based on info from the regressing bug 1651806

The patch landed in nightly and beta is affected.
:mhentges, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(mhentges)

This does not require an uplift because it just addresses a noisy warning, it won't significantly affect downstream.

Flags: needinfo?(mhentges)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: