Unintentional A_SPECIFIC_TARGET warnings being emitted on ./mach build binaries
Categories
(Firefox Build System :: General, defect, P3)
Tracking
(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox79 unaffected, firefox80 wontfix, firefox81 fixed)
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox79 | --- | unaffected |
firefox80 | --- | wontfix |
firefox81 | --- | fixed |
People
(Reporter: kats, Assigned: mhentges)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
When running ./mach build binaries
, at this line, what
is ['binaries']
rather than 'binaries'
(i.e. it's an array of strings, not a string), so the check there always fails. So running ./mach build binaries
with a compilation error always emits the A_SPECIFIC_TARGET warning, which I don't think is what is intended.
Woo duck typing!
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
The "what" value contains a list of build targets, the warning should be printed if any one of the targets is unexpected.
Comment 3•4 years ago
|
||
bugherder |
Comment 4•4 years ago
|
||
Set release status flags based on info from the regressing bug 1651806
Comment 5•4 years ago
|
||
The patch landed in nightly and beta is affected.
:mhentges, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
This does not require an uplift because it just addresses a noisy warning, it won't significantly affect downstream.
Assignee | ||
Updated•4 years ago
|
Description
•