1656303 - Unintentional A_SPECIFIC_TARGET warnings being emitted on ./mach build binaries

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

When running ./mach build binaries, at this line, what is ['binaries'] rather than 'binaries' (i.e. it's an array of strings, not a string), so the check there always fails. So running ./mach build binaries with a compilation error always emits the A_SPECIFIC_TARGET warning, which I don't think is what is intended.

Woo duck typing!

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1656303: Only print $A_SPECIFIC_TARGET warning if one of the targets is not in the allowlist

The "what" value contains a list of build targets, the warning should be printed if any one of the targets is unexpected.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50f9d7d57b92
Only print $A_SPECIFIC_TARGET warning if one of the targets is not in the allowlist r=firefox-build-system-reviewers,rstewart

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/50f9d7d57b92

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1651806

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mhentges, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

This does not require an uplift because it just addresses a noisy warning, it won't significantly affect downstream.