1656317 - Implement entryAdded 'lineNumber' and 'columnNumber' parameters

Status: RESOLVED WONTFIX

(Remote Protocol :: CDP, enhancement, P3)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

All we emit for now is lineNumber: 1

Comment 1

[Dennis Schubert [:denschub]]

ni?'ing myself here for some investigation into this, see the comments in https://phabricator.services.mozilla.com/D163329

Comment 2

[Julian Descottes [:jdescottes]]

Note that columnNumber is not listed in https://chromedevtools.github.io/devtools-protocol/tot/Log/#type-LogEntry, and lineNumber is not hardcoded to 1, at least tested in remote/cdp/test/browser/log/browser_entryAdded.js.

As mentioned in https://phabricator.services.mozilla.com/D163329 the lineNumber should probably be 0-based in order to match Chrome.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also note that in CDP we basically have two different events. Log.entryAdded is for console API and service, while Runtime.exceptionThrown is for Javascript exceptions. The latter has both the column and line number.

Julian when you tried with CDP did Log.entryAdded contain a columnNumber and the docs are just not up to date? It's strange that this is missing.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Our WebDriver BiDi implementation supports that already. As such we are not going to add this to CDP.