Closed
Bug 1656376
Opened 4 years ago
Closed 4 years ago
Parameter order of writeMessage is incorrect
Categories
(Chat Core :: IRC, task)
Chat Core
IRC
Tracking
(thunderbird_esr78 wontfix)
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | wontfix |
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file)
|
2.03 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
The parameter order of writeMessage in the IRC code doesn't match the implementaton in jsProtoHelper.
Note that all the callers give the parameters in the proper order and the IRC implementations essentially just pipe through to the super-class, so all the code works OK, it's just confusing.
|
Assignee | |
Comment 1•4 years ago
|
||
Attachment #9167172 -
Flags: review?(khushil324)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9167172 [details] [diff] [review] Patch v1 Review of attachment 9167172 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil
Attachment #9167172 -
Flags: review?(khushil324) → review+
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
|
||
Updated•4 years ago
|
Target Milestone: --- → 81 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7974df0c5ccb
Fix the parameter ordering of writeMessage for IRC. r=khushil
|
|
||
Updated•4 years ago
|
status-thunderbird_esr78:
--- → affected
|
|
||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•