1656398 - Provide more methods/attribute/event handler on media controller webidl interface

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

If we want to use this interface to construct media hub, we would definitely need more abilities on this interface.

In addition, we might also use this interface to implement media control on GeckoView, which would more fit their requirement. But we would implement that in C++ implementation first because that feature(media control on GV) is targeting on Fx81, which we might be not able to finish this interface to 100% usable on Fx81.

Comment 1

[Alastor Wu [:alwu]]

I've made some patches last week but didn't have time to finish them. Upload those WIP and will continue to work on them later.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part1 : porting media controller's controlling methods.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part2 : add metadata on media controller webidl method.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part3 : using 'getMetadata()' in tests.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part1 : porting media controller's controlling methods

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part2 : add `getMetadata()` on media controller webidl method.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part3 : using 'getMetadata()' in tests.

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part4 : expose `playbackState` on MediaController webidl interface.

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part5 : add event handler `onplaybackstatechange`.

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part6 : use 'controller.playbackState' in test.

Comment 11

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part7 : add event handler 'onmetadatachange'.

Comment 12

[Alastor Wu [:alwu]]

Attachment: Bug 1656398 - part8 : use 'onmetadatachange' in test.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b81b6bf1b140
part1 : porting media controller's controlling methods r=chunmin
https://hg.mozilla.org/integration/autoland/rev/8f48374d8c41
part2 : add `getMetadata()` on media controller webidl method. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/2c22b474652d
part3 : using 'getMetadata()' in tests. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/48a86f2dd6bc
part4 : expose `playbackState` on MediaController webidl interface. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/d0386487d649
part5 : add event handler `onplaybackstatechange`. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/8ae6a224e19f
part6 : use 'controller.playbackState' in test. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/f4c506b647fe
part7 : add event handler 'onmetadatachange'. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/d50f03f8c92f
part8 : use 'onmetadatachange' in test. r=chunmin

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b81b6bf1b140
https://hg.mozilla.org/mozilla-central/rev/8f48374d8c41
https://hg.mozilla.org/mozilla-central/rev/2c22b474652d
https://hg.mozilla.org/mozilla-central/rev/48a86f2dd6bc
https://hg.mozilla.org/mozilla-central/rev/d0386487d649
https://hg.mozilla.org/mozilla-central/rev/8ae6a224e19f
https://hg.mozilla.org/mozilla-central/rev/f4c506b647fe
https://hg.mozilla.org/mozilla-central/rev/d50f03f8c92f