Closed Bug 1656430 Opened 6 months ago Closed 6 months ago

Make `EditorBase::DeleteSelectionWithTransaction()` treat ranges instead

Categories

(Core :: DOM: Editor, task, P2)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(3 files)

It takes rages from Selection. So, if its caller needs to extend deletion range, it needs to modify selection, but it may cause running script and selection range modifying cost is expensive. So, we should make it take array of ranges instead.

This new class will be used for treating selection ranges without modifying
it temporarily.

Depends on D85684

This patch makes EditorBase::DeleteSelectionWithTransaction() a wrapper of
EditorBase::DeleteRangesWithTransaction().

Depends on D85685

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/5ac723a3f79c
part 1: Rename `AutoRangeArray` to `AutoSelectionRangeArray` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/33bb59691c3b
part 2: Add `AutoRangeArray` for alternative class of `Selection` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5795a17492a5
part 3: Create `EditorBase::DeleteRangesWithTransaction()` r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.