1656430 - Make `EditorBase::DeleteSelectionWithTransaction()` treat ranges instead

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It takes rages from Selection. So, if its caller needs to extend deletion range, it needs to modify selection, but it may cause running script and selection range modifying cost is expensive. So, we should make it take array of ranges instead.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656430 - part 1: Rename `AutoRangeArray` to `AutoSelectionRangeArray` r=m_kato!

Depends on D85683

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656430 - part 2: Add `AutoRangeArray` for alternative class of `Selection` r=m_kato!

This new class will be used for treating selection ranges without modifying
it temporarily.

Depends on D85684

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1656430 - part 3: Create `EditorBase::DeleteRangesWithTransaction()` r=m_kato!

This patch makes EditorBase::DeleteSelectionWithTransaction() a wrapper of
EditorBase::DeleteRangesWithTransaction().

Depends on D85685

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ac723a3f79c
part 1: Rename `AutoRangeArray` to `AutoSelectionRangeArray` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/33bb59691c3b
part 2: Add `AutoRangeArray` for alternative class of `Selection` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5795a17492a5
part 3: Create `EditorBase::DeleteRangesWithTransaction()` r=m_kato

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5ac723a3f79c
https://hg.mozilla.org/mozilla-central/rev/33bb59691c3b
https://hg.mozilla.org/mozilla-central/rev/5795a17492a5