PK11_WrapPrivKey memory leak

RESOLVED FIXED in 3.6

Status

NSS
Libraries
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Steve Parkinson, Assigned: Robert Relyea)

Tracking

({memory-leak})

3.4.2
x86
Windows 2000
memory-leak

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
During a purify run of a test tool of mine, I
discovered that PK11_WrapPrivKey() leaks a little memory.

Specifically, 'param' is never freed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: mlk
(Assignee)

Comment 1

16 years ago
Created attachment 99897 [details] [diff] [review]
Free params if we allocated them

Good catch. The code already was set up to handle the case where it needed to
free the params, it just didn't get around to doing it.
(Assignee)

Comment 2

16 years ago
Setting target milestone. wtc, could I have a review of this.

bob
Target Milestone: --- → 3.6

Comment 3

16 years ago
Comment on attachment 99897 [details] [diff] [review]
Free params if we allocated them

r=wtc.	Bob, your patch is correct.
Attachment #99897 - Flags: review+
(Assignee)

Comment 4

16 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.