Closed Bug 16566 Opened 25 years ago Closed 25 years ago

Enable compilation of prlog.c functions in optimized build

Categories

(NSPR :: NSPR, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: larryh, Assigned: srinivas)

Details

SeaMonkey, Mozilla requested that the functions performing logging in prlog.c be
enabled (not compiled away with '#ifdef PR_LOGGING') in optimized builds.

Note that PR_Abort() and PR_Assert() wil continut to be compiled out of the
optimized build.
Yes, logging should be enabled in the optimized builds. Larry, do you want to
work in this one?
Status: NEW → ASSIGNED
Yes. I have already created the update. Wan-Teh reviewed it. I will check it in
when the tree is open.
Checking in pr/src/misc/prinit.c;
/cvsroot/mozilla/nsprpub/pr/src/misc/prinit.c,v  <--  prinit.c
new revision: 3.16; previous revision: 3.15
done
Checking in pr/src/io/prlog.c;
/cvsroot/mozilla/nsprpub/pr/src/io/prlog.c,v  <--  prlog.c
new revision: 3.13; previous revision: 3.12
done
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I changed prlog.c so that it defines PR_Assert only if
DEBUG is defined.  This is to be consistent with prlog.h,
which declares PR_Assert only if DEBUG is defined.
/cvsroot/mozilla/nsprpub/pr/src/io/prlog.c, revision 3.14

Checked in the fix into the internal repository.
/m/src/ns/nspr20/pr/src/io/prlog.c, revision 2.18
/m/src/ns/nspr20/pr/src/misc/prinit.c, revision 2.36
You need to log in before you can comment on or make changes to this bug.