Closed Bug 1656610 Opened 4 years ago Closed 4 years ago

PictureInPictureChild sometimes doesn't think short videos that are playing are actually playing

Categories

(Toolkit :: Video/Audio Controls, defect, P3)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: mconley, Assigned: tracy)

References

Details

Attachments

(1 file)

Because the Picture-in-Picture toggle only appears by default on videos of length 45s or longer, I don't expect that this is actually a problem for real users out in the wild, but this is biting us for short videos in our test suite.

For short videos that have just started playing, I believe this line here: https://searchfox.org/mozilla-central/rev/03794edd6edcc3fc1e222de966cb27256ce08998/toolkit/actors/PictureInPictureChild.jsm#965

will report that the currentTime is 0, despite the video already playing and looping. I think we don't need to check that the video's currentTime is > 0 - I think we can remove that condition altogether.

Blocks: 1656016
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c06ff10c075
Remove condition that checks the video's currentTime is > 0 r=Gijs
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: