1656680 - Permafailing browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected +0 when Gecko 81 merges to Beta on 2020-08-24

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Natalia Csoregi [:nataliaCs]]

Central as Beta:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=78dd7ddb1389a42dba2ebfad33c57fbaf9213ab4&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fstatic%2Fbrowser.ini&group_state=expanded

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311738883&repo=try&lineNumber=1403

[task 2020-08-01T12:14:36.906Z] 12:14:36 INFO - indirectly whitelisted file: resource://services-sync/doctor.js used from resource://services-sync/bookmark_repair.js,resource://services-sync/stages/enginesync.js
[task 2020-08-01T12:14:36.907Z] 12:14:36 INFO - Buffered messages finished
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected +0
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - Stack trace:
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:950
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: resource://gre/localization/en-US/toolkit/about/aboutGlean.ftl -
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - Stack trace:
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-08-01T12:14:36.909Z] 12:14:36 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:954
[task 2020-08-01T12:14:36.910Z] 12:14:36 INFO - ignored unused whitelist entry: resource://app/blocklist.xml
[task 2020-08-01T12:14:36.912Z] 12:14:36 INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json
[task 2020-08-01T12:14:36.912Z] 12:14:36 INFO - ignored unused whitelist entry: resource://gre/res/test.properties
[task 2020-08-01T12:14:36.912Z] 12:14:36 INFO - missing file: chrome://global/content/aboutProcesses.html

Possibly related to Bug 1647187 ?

Comment 1

[Cosmin Sabou [:CosminS]]

unreferenced file: resource://gre/localization/en-US/toolkit/about/aboutGlean.ftl points to Bug 1635253.
Chris, do you mind taking a look at this beta-sim bug? Thank you.

Comment 2

[Intermittent Failures Robot]

2 failures in 4289 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform breakdown:

• windows10-64-shippable: 1
• windows10-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1656680&startday=2020-07-27&endday=2020-08-02&tree=all

Comment 3

[Chris H-C :chutten]

Hm...

about:glean is only included when MOZ_GLEAN is set. MOZ_GLEAN is, for now, only set on (non-Android) Nightly.

I'm not sure how to mark about:glean's translations are to be conditionally included... :flod, can you help me?

Comment 4

[Francesco Lodolo [:flod]]

Not really my area, but I can't help noticing several FTL files excluded in that test
https://searchfox.org/mozilla-central/source/browser/base/content/test/static/browser_all_files_referenced.js#87

Front-end folks like Gijs or Jaws might know if that's the correct approach here.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Chris H-C :chutten from comment #3)

Hm...

about:glean is only included when MOZ_GLEAN is set. MOZ_GLEAN is, for now, only set on (non-Android) Nightly.

I'm not sure how to mark about:glean's translations are to be conditionally included... :flod, can you help me?

Comment 6

[Chris H-C :chutten]

If the information in bug 1526672 is still valid these 2 years later, looks like that allowlist is the way to go.

Comment 7

[:Gijs (he/him)]

(In reply to Chris H-C :chutten from comment #6)

If the information in bug 1526672 is still valid these 2 years later, looks like that allowlist is the way to go.

Yeah, add an item to the allowlist iff the conditions for it being referenced match.

Comment 8

[Chris H-C :chutten]

Dang. The allowlist has an integrity test to ensure all items are used. Not all items are used in Nightly builds, and there's no current way to ifdef out on channel.

Lemme augment the allowlist's capabilities. Sorry I couldn't get to this today.

Comment 9

[:Gijs (he/him)]

(In reply to Chris H-C :chutten from comment #8)

Dang. The allowlist has an integrity test to ensure all items are used. Not all items are used in Nightly builds, and there's no current way to ifdef out on channel.

There is already such a way - see e.g. https://searchfox.org/mozilla-central/rev/a315a1a0f09550e23e4590a77e74f36543315da3/browser/base/content/test/static/browser_all_files_referenced.js#228-234 .

Comment 10

[Chris H-C :chutten]

(In reply to :Gijs (he/him) from comment #9)

(In reply to Chris H-C :chutten from comment #8)

Dang. The allowlist has an integrity test to ensure all items are used. Not all items are used in Nightly builds, and there's no current way to ifdef out on channel.

There is already such a way - see e.g. https://searchfox.org/mozilla-central/rev/a315a1a0f09550e23e4590a77e74f36543315da3/browser/base/content/test/static/browser_all_files_referenced.js#228-234 .

Ah, thank you. Patch incoming.

Comment 11

[Chris H-C :chutten]

Attachment: Bug 1656680 - Allow aboutGlean.ftl to be unreferenced r?Gijs!

But only on not-nightly or android builds.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1552fde523bc
Allow aboutGlean.ftl to be unreferenced r=Gijs

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1552fde523bc

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's central-as-beta simulation.