Closed Bug 1656839 Opened 4 years ago Closed 4 years ago

nsNativeBasicThemeGTK.cpp:9:10: error: ‘StaticRefPtr’ does not name a type

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

with gcc 10:

In file included from Unified_cpp_widget_gtk2.cpp:2:
/root/firefox-gcc-last/widget/gtk/nsNativeBasicThemeGTK.cpp: In function ‘already_AddRefed<nsITheme> do_GetBasicNativeThemeDoNotUseDirectly()’:
/root/firefox-gcc-last/widget/gtk/nsNativeBasicThemeGTK.cpp:9:10: error: ‘StaticRefPtr’ does not name a type
    9 |   static StaticRefPtr<nsITheme> gInstance;
      |          ^~~~~~~~~~~~
In file included from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/Assertions.h:18,
                 from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/EndianUtils.h:69,
                 from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/gfx/Types.h:11,
                 from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/gfx/Coord.h:11,
                 from /root/firefox-gcc-last/layout/base/Units.h:12,
                 from /root/firefox-gcc-last/widget/nsNativeBasicTheme.h:10,
                 from /root/firefox-gcc-last/widget/gtk/nsNativeBasicThemeGTK.h:10,
                 from /root/firefox-gcc-last/widget/gtk/nsNativeBasicThemeGTK.cpp:6,
                 from Unified_cpp_widget_gtk2.cpp:2:
̀```
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a5cab9f413f
nsNativeBasicThemeGTK.cpp add a missing mozilla:: to unbreak the build with gcc r=spohl

I'm seeing this with Clang (and it should be the mozbuild Clang, too). But I don't have Wayland support enabled, which might be changing whether that file ends in the same unified build bundle as a file with using namespace mozilla.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: