Closed Bug 1656875 Opened 10 months ago Closed 10 months ago

Make Event subdialogs themeable

Categories

(Calendar :: General, task)

Product:
Calendar
Component:
General
Type:
task

Tracking

(thunderbird_esr78 fixed, thunderbird80 fixed)

Status:
VERIFIED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed
thunderbird80 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

(Whiteboard: [TM:78.2.0])

Attachments

(3 files)

1656875-event-subdialog-themeable.patch
25.94 KB, patch
pmorris
: review+
Details | Diff | Splinter Review
1656875-event-subdialog-themeable-beta.patch
27.00 KB, patch
pmorris
: approval-calendar-beta+
Details | Diff | Splinter Review
1656875-event-subdialog-themeable-ESR.patch
27.00 KB, patch
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review

We can make more dialogs, like the recurrence, reminder and the timezone, themeable. Also converting the calendar properties dialog is simple.

I added the centerscreen attribute to make the dialogs open related to the existing window/dialog and not somewhere on the screen. They are modal, so they should cover the opening window/dialog to give feedback that you have to edit them first and can't on the other during they are open. Ubuntu does this already with showing the dialogs as a subdialog but not Windows.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9167666 - Flags: review?(paul)
Whiteboard: [TM:78.2.0]
Comment on attachment 9167666 [details] [diff] [review]
1656875-event-subdialog-themeable.patch

Review of attachment 9167666 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good to me.
Attachment #9167666 - Flags: review?(paul) → review+
Keywords: checkin-needed-tb
Target Milestone: --- → 81 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ae90541a3ecd
Make Event subdialogs themeable. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/fe84f0fbb17c
follow-up - Fix a broken test. rs=bustage-fix a=me

Patch with the test fix for beta.

Attachment #9168073 - Flags: approval-calendar-beta?(paul)

[Approval Request Comment]
User impact if declined: non-themed dialogs
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Can land in TB 78.2

Attachment #9168074 - Flags: approval-comm-esr78?
Attachment #9168073 - Flags: approval-calendar-beta?(paul) → approval-calendar-beta+

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b791ea290a73

Comment on attachment 9168074 [details] [diff] [review]
1656875-event-subdialog-themeable-ESR.patch

[Triage Comment]
Approved for esr78

Attachment #9168074 - Flags: approval-comm-esr78? → approval-comm-esr78+

Looked good in my tests of 80.0b2 and 80.0b4 on Ubuntu 18.04.4(5?) LTS

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.