1656875 - Make Event subdialogs themeable

Status: VERIFIED FIXED

(Calendar :: General, task)

Description

[Richard Marti (:Paenglab)]

We can make more dialogs, like the recurrence, reminder and the timezone, themeable. Also converting the calendar properties dialog is simple.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1656875-event-subdialog-themeable.patch

I added the centerscreen attribute to make the dialogs open related to the existing window/dialog and not somewhere on the screen. They are modal, so they should cover the opening window/dialog to give feedback that you have to edit them first and can't on the other during they are open. Ubuntu does this already with showing the dialogs as a subdialog but not Windows.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9167666 [details] [diff] [review]
1656875-event-subdialog-themeable.patch

Review of attachment 9167666 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ae90541a3ecd
Make Event subdialogs themeable. r=pmorris

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe84f0fbb17c
follow-up - Fix a broken test. rs=bustage-fix a=me

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1656875-event-subdialog-themeable-beta.patch

Patch with the test fix for beta.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1656875-event-subdialog-themeable-ESR.patch

[Approval Request Comment]
User impact if declined: non-themed dialogs
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Can land in TB 78.2

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b791ea290a73

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9168074 [details] [diff] [review]
1656875-event-subdialog-themeable-ESR.patch

[Triage Comment]
Approved for esr78

Comment 9

[Geoff Lankow (:darktrojan)]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/65d079f7ba47

Comment 10

[WaltS48 [:walts48]]

Looked good in my tests of 80.0b2 and 80.0b4 on Ubuntu 18.04.4(5?) LTS