1656992 - StopSSLServerCertVerificationThreads() introduces shutdown hang crashes

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Junior [inactive]]

@ shutdownhang | __psynch_cvwait | <name omitted> | mozilla::TaskController::GetRunnableForMTTask ](https://crash-stats.mozilla.org/signature/?signature=shutdownhang%20%7C%20__psynch_cvwait%20%7C%20%3Cname%20omitted%3E%20%7C%20mozilla%3A%3ATaskController%3A%3AGetRunnableForMTTask&date=%3E%3D2020-07-27T20%3A26%3A00.000Z&date=%3C2020-08-03T20%3A26%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#reports)
Looks like mozilla::psm::StopSSLServerCertVerificationThreads() introduces this.
examples:
https://crash-stats.mozilla.org/report/index/06383cb3-0c3d-4b03-b5c9-235330200802#allthreads
https://crash-stats.mozilla.org/report/index/90d037e6-b97d-49af-b2ee-072010200802#allthreads

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1656992 - osclientcerts: disable AIA fetching when looking for issuer certificates (macOS) r?kjacobs

When the macOS osclientcerts backend looks for issuer certificates, it can
result in network I/O unless it is specifically disabled. The Windows backend
already handles this, so this only applies to macOS.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2be8c892ca05
osclientcerts: disable AIA fetching when looking for issuer certificates (macOS) r=kjacobs

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2be8c892ca05

Comment 4

[Junior [inactive]]

Does it only happen on nightly? I don't see there's a crash in beta.
I'm wondering if it should be uplifted.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

osclientcerts is only enabled by default in nightly, so this would only affect people who have manually enabled it. I don't think we need to uplift this unless we're seeing crashes from it.