1657087 - Logic error in OOM check in nsStyleImageLayers::operator=(nsStyleImageLayers&& aOther)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Simon Giesecke [:sg] [he/him]]

nsStyleImageLayers::operator=(nsStyleImageLayers&& aOther) contains a check for an OOM condition, which cannot occur here, and furthermore checks for it in a wrong way.

The copy assignment operator nsStyleImageLayers::operator=(cons tnsStyleImageLayers& aOther) is correct in this regard, but also relies on implementation details to detect the OOM condition.

This should be improved by providing proper fallible operations on nsStyleAutoArray rather that checking indirectly for OOM conditions.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1657087 - Fix fallible behaviour of nsStyleAutoArray and nsStyleImageLayers. r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85764389f706
Fix fallible behaviour of nsStyleAutoArray and nsStyleImageLayers. r=emilio

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/85764389f706