1657155 - Land a Telemetry probe that increments a counter every time the Picture-in-Picture toggle appears

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

We want this as part of the toggle experiment.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1657155 - Add a Telemetry probe scalar for how many times the PiP toggle is shown. r?mstriemer!,data-review=chutten

Comment 2

[Mike Conley (:mconley) (:⚙️)]

ni?ing myself to get a data-review form posted.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Data review request.md

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Note that since the experiment is targeted for Firefox 80, we plan to request a beta uplift.

Comment 5

[Chris H-C :chutten]

Comment on attachment 9168001 [details]
Data review request.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 87.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :mconley is responsible for renewing or removing the collection before it expires in Firefox 87.

---
Result: datareview+

Comment 6

[Mike Conley (:mconley) (:⚙️)]

ni?ing myself to request beta uplift once this lands in central.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d2a1392d15b
Add a Telemetry probe scalar for how many times the PiP toggle is shown. r=mstriemer,data-review=chutten

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9d2a1392d15b

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9167956 [details]
Bug 1657155 - Add a Telemetry probe scalar for how many times the PiP toggle is shown. r?mstriemer!,data-review=chutten

Beta/Release Uplift Approval Request

• User impact if declined: None, but it will be a lot harder for us to draw meaningful conclusions from one of our upcoming experiments.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds a new, very simple Telemetry probe, that increments a counter every time the user sees a Picture-in-Picture toggle.
• String changes made/needed: None.

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9167956 [details]
Bug 1657155 - Add a Telemetry probe scalar for how many times the PiP toggle is shown. r?mstriemer!,data-review=chutten

approved for 80.0b6

Comment 11

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5f4fb071ff27